Bug 274045

Summary:	wrong weeksInYear() declaration in kcalendarsystem.h
Product:	[Unmaintained] kdelibs	Reporter:	Andrea Scarpino <scarpino>
Component:	kdecore	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jlayt, rdieter
Priority:	NOR
Version First Reported In:	SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Andrea Scarpino 2011-05-24 17:51:38 UTC

Version:           SVN (using Devel) 
OS:                Linux

a bug has been introduced with this commit:
http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=b9201497f65bc7097c7c2a6b83eaa68891463b32

The KCalendarSystem::weeksInYear(QDate const&,
KLocale::WeekNumberSystem) const is declared in kdecore/date/kcalendarsystem.h,
but there is no implementation in kdecore/date/kcalendarsystem.cpp

This is causing smokekde build to fail with:
Linking CXX shared library ../lib/libsmokekdecore.so
CMakeFiles/smokekdecore.dir/x_2.o: In function
`__smokekdecore::xcall_KCalendarSystem(short, void*, Smoke::StackItem*)':
x_2.cpp:(.text+0x251f): undefined reference to
`KCalendarSystem::weeksInYear(QDate const&, KLocale::WeekNumberSystem) const'
collect2: ld returned 1 exit status
make[2]: *** [lib/libsmokekdecore.so.3.0.0] Error 1
make[1]: *** [kdecore/CMakeFiles/smokekdecore.dir/all] Error 2
make: *** [all] Error 2

Reproducible: Didn't try

Steps to Reproduce:
install kdelibs 4.6.80/git
try to build smokekde 4.6.80/git

Actual Results:  
build fails

Comment 1 John Layt 2011-05-25 09:59:21 UTC

Thanks, already fixed in commit http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=4d8b9099b63cc66bb71ef97aece3df67bdb6ee9b