Bug 273898

Summary:	Ctrl + E is mapped to two different conflicting functions
Product:	[Applications] krita	Reporter:	Kubuntiac <user581>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	halla, info, sven.langkamp
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Kubuntiac 2011-05-22 22:15:55 UTC

...and gives "The shortcut Ctrl + E is ambiguous."

Specifically it's mapped to both "merge layer with layer below" and also "select similar colours"

It seems that a unit test to check for duplicate shortcuts could be useful. ;P

Comment 1 Halla Rempt 2011-07-21 11:01:16 UTC

We only have runtime checker for that... But I've resolved this duplication.

Comment 2 Sven Langkamp 2011-08-12 20:55:52 UTC

Git commit 803db2fae6072f9aa294150d6790c82ee39b74d3 by Sven Langkamp.
Committed on 12/08/2011 at 22:53.
Pushed by langkamp into branch 'master'.

add a check for colliding shortcuts, not active by default as there are colliding shortcuts
CCBUG:273898

M  +13   -0    krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/803db2fae6072f9aa294150d6790c82ee39b74d3

Comment 3 Sven Langkamp 2011-08-12 21:02:38 UTC

There are still ten shortcuts that are conflicting. Mostly between some tool, so not imidiately noticeable.

Comment 4 Inge Wallin 2011-08-16 08:09:49 UTC

Git commit b7ebd41094efefd184028d6baa44435d1e00bd4f by Inge Wallin, on behalf of Sven Langkamp.
Committed on 12/08/2011 at 22:53.
Pushed by ingwa into branch 'nondestructive-unavail-leinir'.

add a check for colliding shortcuts, not active by default as there are colliding shortcuts
CCBUG:273898

M  +13   -0    krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/b7ebd41094efefd184028d6baa44435d1e00bd4f

Comment 5 Halla Rempt 2011-10-16 14:18:25 UTC

Sven, do you have a list of those?

Comment 6 Sven Langkamp 2012-07-10 20:41:10 UTC

The list:
krita(7508) KisView2::KisView2: "Select &All"   QKeySequence("Ctrl+A")
krita(7508) KisView2::KisView2: "Dese&lect"   QKeySequence("Ctrl+Shift+A")
krita(7508) KisView2::KisView2: "Fill with Background Color"   QKeySequence("Backspace")
krita(7508) KisView2::KisView2: "Add new paint layer"   QKeySequence("Ins")
krita(7508) KisView2::KisView2: "&Raise"   QKeySequence("Ctrl+]")
krita(7508) KisView2::KisView2: "&Lower"   QKeySequence("Ctrl+[")
krita(7508) KisView2::KisView2: "Show common colors"   QKeySequence("C")
krita(7508) KisView2::KisView2: "To Path"   QKeySequence("P")
krita(7508) KisView2::KisView2: "Remove point"   QKeySequence("Backspace")
krita(7508) KisView2::KisView2: "Segment to Curve"   QKeySequence("C")
krita(7508) KisView2::KisView2: "Insert point"   QKeySequence("Ins")
krita(7508) KisView2::KisView2: "Join with segment"   QKeySequence("J")
krita(7508) KisView2::KisView2: "Select &All"   QKeySequence("Ctrl+A")
krita(7508) KisView2::KisView2: "Dese&lect"   QKeySequence("Ctrl+Shift+A")
krita(7508) KisView2::KisView2: "Select a color from the image or current layer"   QKeySequence("P")
krita(7508) KisView2::KisView2: "Select an elliptical area"   QKeySequence("J")
krita(7508) KisView2::KisView2: "Rotate Canvas Right"   QKeySequence("Ctrl+]")
krita(7508) KisView2::KisView2: "Rotate Canvas Left"   QKeySequence("Ctrl+[")

Comment 7 Sven Langkamp 2013-01-31 17:56:08 UTC

*** Bug 313999 has been marked as a duplicate of this bug. ***