| Summary: | Crash on Gnucash import | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | toquehead |
| Component: | general | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version First Reported In: | 4.5.3 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
toquehead
2011-05-21 05:32:11 UTC
Before attempting the import, I did a "Check & Repair All" in Gnucash. The error message reported is: Import failed: Input file cannot be parsed; may be corrupt error triggered by consumer The gnucash file I was importing was on a Windows drive accessed via a VMWare "Shared Folder". When I copied the file to my Ubuntu home dir the import completed OK. An easy workaround, but perhaps there should be some error handling upon failure to read the import file. I did also note the gnucash import crashed if my gnucash file was compressed. SVN commit 1233113 by conet:
BUG: 273770
Replace all usage of qFatal with qWarning in KMyMoney. I mean I've heard of assertive programming but this pushes it over the edge. qFatal('Can't open file') - I prefer letting the user know that there was an error and keep running to bringing down the whole application (it provides a feeling of instability) over a file open failure.
If I went too far with this change sorry but I prefer discussing re-adding the qFatal calls on a point-by-point basis. In most cases it's a shortcut for poor error handling.
M +13 -13 converter/mymoneygncreader.cpp
M +1 -1 converter/webpricequote.cpp
M +1 -1 mymoney/mymoneyfile.cpp
M +1 -1 mymoney/mymoneytransactionfilter.cpp
M +1 -1 mymoney/storage/mymoneydbdriver.cpp
M +2 -2 mymoney/storage/mymoneystoragesql.cpp
M +1 -1 views/kscheduledview.cpp
M +1 -1 wizards/newloanwizard/keditloanwizard.cpp
WebSVN link: http://websvn.kde.org/?view=rev&revision=1233113
|