Bug 273585

Summary:	Doesn't compile due to KIMAGECACHE/doesn't fall back to KPIXMAPCACHE
Product:	[Applications] amarok	Reporter:	Thierry Göckel <thierry>
Component:	general	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	major	CC:	alex.merry
Priority:	HI
Version First Reported In:	2.4-GIT
Target Milestone:	2.4.2
Platform:	Debian unstable
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	2.4.2
Sentry Crash Report:

Description Thierry Göckel 2011-05-18 22:19:01 UTC

Version:           2.4-GIT (using KDE 4.4.5) 
OS:                Linux

d4aa91efcbb9568ddf5fcc338c22c8337147b5aa commit says cmake would detect whether kimagecache is available or not and then fall back to kpixmapcache for older kde versions.
Debian still has kde 4.4.5 and thus compilation fails.

Reproducible: Always

Steps to Reproduce:
clean src and build dirs, cmake && make -j3

Actual Results:  
fails "kde/src/amarok/src/ImageCache.h:93:49: error: void value not ignored as it ought to be"

Expected Results:  
compile

Comment 1 Alex Merry 2011-05-23 02:31:18 UTC

Git commit 93e5d09a1360f3850957ca1aa35a54ccedbe31c9 by Alex Merry.
Committed on 23/05/2011 at 02:11.
Pushed by alexmerry into branch 'master'.

Fix compile with kdelibs 4.4

KPixmapCache::insert returns void, not bool, so always return true when
using KPixmapCache.

Also, use #ifdef HAVE_KIMAGECACHE, not #if HAVE_KIMAGECACHE, to avoid
"undefined macro" warnings.

BUG: 273585

M  +12   -11   src/ImageCache.h     

http://commits.kde.org/amarok/93e5d09a1360f3850957ca1aa35a54ccedbe31c9