Bug 272252

Summary: Contrast setting is not applied when changing a color scheme
Product: [Applications] systemsettings Reporter: Nikita Churaev <lamefun.x0r>
Component: kcm_colorsAssignee: Matthew Woehlke <mwoehlke.floss>
Status: RESOLVED NOT A BUG    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: fïx

Description Nikita Churaev 2011-05-02 16:31:44 UTC 
Version:           unspecified
OS:                Linux

Eg. Oxygen.colors contains

[KDE]
contrast=8

Reproducible: Always

Steps to Reproduce:
1. Change color scheme to Oxygen
2. Change your contrast to 1 in options tab
3. Get back to Scheme tab and notice what color scheme is selected
4. Change color scheme to any other and then back to Oxygen

Actual Results:  
3 - The color scheme should change to Current, because contrast value is different than in color scheme
4 - Colors change, but contrast doesn't

Expected Results:  
3 - Color scheme should change to Current
4 - Colors and contrast change
Comment 1 Nikita Churaev 2011-12-22 11:11:49 UTC 
Created attachment 67010 [details]
fïx

This patch should fix the bug.
Comment 2 Nikita Churaev 2011-12-22 11:18:50 UTC 
Comment on attachment 67010 [details]
fïx

Nees more wörk.
Comment 3 Matthew Woehlke 2011-12-22 20:45:25 UTC 
I'm not sure this is actually a bug? Based solely on some quick observations, nothing in the Options tab appears to be associated with the scheme; they appear to be orthogonal. Which didn't surprise me, and is what I'm inclined to say is the desired behavior.

That said... the current behavior appears to be that changing options does not change the scheme, nor does changing the scheme change the options. If we change that, both need to change (maybe why you withdrew your proposed patch?).
Comment 4 Nikita Churaev 2011-12-25 17:48:22 UTC 
Yes, that's a bug in kdelibs, which has two functions for contrast that return different default values. Oxygen uses one with default 7 and kcm_colors uses one with default 5, so when the user uses kcm_colors the first time, contrast appears to change.

This is real patch: https://git.reviewboard.kde.org/r/103529/