Summary: | DigiKam crash on deleting tags (quickly) | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Tristan <trisroger> |
Component: | Tags-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | 1.9.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.0.0 | |
Sentry Crash Report: |
Description
Tristan
2011-04-30 03:47:45 UTC
This is a bug of a reentered event loop. Three times recursive in fact (ContextMenuHelper::exec -> KMessageBox -> ...) I'll need to think how to best prevent that. Normally, the message box should be model so that subsequent events are not generated, but obviously event are already in the loop and then processed. Git commit 59e5acd4f132b3b585644d2f470e79b3bb185284 by Marcel Wiesweg. Committed on 15/05/2011 at 16:51. Pushed by mwiesweg into branch 'master'. Strictly use AlbumPointer safeguards whereever a dialog (=event loop) is entered. Remove the parentTag mechanism, instead store the tag in the QAction. Hopefully fixes the crash on rapid deletion with recursive event loops. BUG: 272023 M +2 -1 NEWS M +4 -0 digikam/album/albummanager.h M +3 -5 digikam/tags/tagfolderview.cpp M +35 -31 digikam/tags/tagmodificationhelper.cpp M +12 -7 digikam/tags/tagmodificationhelper.h M +6 -3 digikam/utils/contextmenuhelper.cpp M +4 -3 digikam/utils/contextmenuhelper.h http://commits.kde.org/digikam/59e5acd4f132b3b585644d2f470e79b3bb185284 |