Bug 271640

Summary:	[regression] Commit e95e0f8e filtering of unread articles causes a bug
Product:	[Applications] akregator	Reporter:	Elias Probst <mail>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alex.merry, christopherheiny, dilfridge, j__n, nicolas.degand, oliver, squan, steve, tiposchi, vitorboschi, xrigou, yester64
Priority:	NOR
Version:	GIT (master)
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Elias Probst 2011-04-24 20:13:23 UTC

Version:           unspecified
OS:                Linux

Since commit e95e0f8e, filtering unread articles causes a bug.
When clicking on an unread article while showing only unread articles, the clicked article and the next one are instantly marked as read and both disappear from the list.

Reproducible: Always

Steps to Reproduce:
1. Checkout Akregator e95e0f8e or newer
2. Open Akregator
3. Go to a folder which contains some unread articles
4. Set the filter to 'Unread'
5. Click on an unread article

Actual Results:  
The clicked article and the next item in the list are marked as unread and disappear immediately from the list.

Expected Results:  
Only the clicked article should be marked as read, not also another one in the list.

The clicked article should remain in the list unless another one is clicked.
Otherwise it is not easily possible to run further operations on this article (e.g. right click on it → Mark as unread).

Comment 1 Christophe Marin 2011-04-24 20:57:19 UTC

Alex, commit e95e0f8e is your sorting fix for new articles. Can you have a look at this please ?

Comment 2 Christophe Marin 2011-04-24 22:05:49 UTC

Bug 271149 may also be related

Comment 3 Christos Gourdoupis 2011-04-25 18:49:00 UTC

I am experiencing this too. It seems that the reporter has configured his client to "Mark selected article read after 0 sec". By raising the timeout a bit you can view the next article disappear a few secs later than the current.

Comment 4 Andreas K. Huettel 2011-04-27 14:00:20 UTC

Same observed in Gentoo akregator-4.4.11.1. Fixed in Gentoo akregator-4.4.11.1-r1 by reverting kde commit a70973b91b6dd2b14462a114ce2c0b520e41b3af.

Comment 5 j__n 2011-04-28 04:21:26 UTC

also appears in debian packages.

Akregator
Version 1.6.6
Using KDE Development Platform 4.6.2 (4.6.2)

2.6.38-2-686

Comment 6 Christophe Marin 2011-04-28 11:22:12 UTC

bug 271794 is also a regression introduced by this change

Comment 7 Christophe Marin 2011-04-28 12:02:29 UTC

Git commit 1380ce172e4f98ab433085721f0e8fddef4ba621 by Christophe Giboudeaux.
Committed on 28/04/2011 at 11:34.
Pushed by cgiboudeaux into branch '4.6'.

Revert "Maintain sort order when new articles are added"

While fixing the new article sorting issue, this introduced regressions
when displaying only unread articles.

Alex, please fix and resubmit to kdepim/4.6.
BUG: 271794
BUG: 271149
CCBUG: 271640
FIXED-IN: kdepim 4.6

This reverts commit e95e0f8e3687137f02e19d3ecf5ea0a9463f5962.

M  +0    -3    akregator/src/articlelistview.cpp     

http://commits.kde.org/kdepim/1380ce172e4f98ab433085721f0e8fddef4ba621

Comment 8 Christophe Marin 2011-04-30 15:14:31 UTC

*** Bug 271860 has been marked as a duplicate of this bug. ***

Comment 9 Oliver 2011-05-01 13:35:29 UTC

I noticed this really anoying bug too with

akregator 1.6.6
kde 4.6.2
Linux version 2.6.38-ARCH

Comment 10 Christophe Marin 2011-05-18 12:27:24 UTC

*** Bug 273526 has been marked as a duplicate of this bug. ***

Comment 11 Christophe Marin 2011-05-28 22:43:03 UTC

*** Bug 274383 has been marked as a duplicate of this bug. ***

Comment 12 Christophe Marin 2011-06-16 15:15:01 UTC

'Fixed' (well, kinda) in kdepim 4.6

Comment 13 S. Bryant 2011-07-07 21:23:12 UTC

Just updated to KDE SC 4.6.5 (OpenSUSE RPMs, x86_64); Kontact 4.4.11/Akregator 1.6.6.

I can confirm that this bug is still present.  FWIW, it was there in KDE SC 4.6.4 too.

Perhaps the 'revert' did not work?
This is definately not fixed yet.

Steve

Comment 14 Christophe Marin 2011-07-07 21:36:18 UTC

(In reply to comment #13)
> Just updated to KDE SC 4.6.5 (OpenSUSE RPMs, x86_64); Kontact 4.4.11/Akregator
> 1.6.6.

[...]

> Perhaps the 'revert' did not work?
> This is definately not fixed yet.
> 

What about reading the comment just before yours ?

> 'Fixed' (well, kinda) in kdepim 4.6

Comment 15 S. Bryant 2011-07-08 07:53:40 UTC

Hi Christophe,

> What about reading the comment just before yours ?
> > 'Fixed' (well, kinda) in kdepim 4.6

Are you saying that this regression in kdepim 4.4 can only be fixed by going to 4.6, with all the other changes that entails?  A number of distributions aren't even offering kdepim-4.6 yet.
We need a fix in the same branch where the breakage occurred, otherwise it's not really fixed!

Steve

Comment 16 Christophe Marin 2011-07-08 08:16:24 UTC

Exactly. the kdepim 4.4 branch is now closed.

Obviously, you can pick the commit and ask your distribution to add it to their kdepim 4.4.11 package (see comment #7 for the link)

Comment 17 Christophe Marin 2011-07-11 13:16:32 UTC

*** Bug 277546 has been marked as a duplicate of this bug. ***