Bug 271353

Summary: Don‘t change width of Show more/Show less button
Product: [Unmaintained] solid Reporter: Kai Uwe Broulik <KaiUweBroulik2>
Component: networkmanagementAssignee: Will Stephenson <wstephenson>
Status: RESOLVED FIXED    
Severity: wishlist CC: pino
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Kai Uwe Broulik 2011-04-20 15:07:25 UTC 
Version:           unspecified (using KDE 4.6.2) 
OS:                Linux

When clicking the button Show more / Show less, it changes its width according to its label. This causes really laggy resizing of the plasmoid content (the lag is a global Plasma issue) and scroll bars appearing briefly and it just doesn‘t feel good.
And I doubt that any language has a word for “more” that is much longer than “less”, in German for example “Weniger anzeigen” is a bit wider than “Mehr anzeigen” but it is so annoying that it changes its size.
Make the button width fixed.

Reproducible: Always
Comment 1 Lamarque V. Souza 2011-04-20 16:47:04 UTC 
Git commit 56cabdf905f538eede41f6cd9816e369359f640b by Lamarque V. Souza.
Committed on 20/04/2011 at 16:53.
Pushed by lvsouza into branch 'master'.

Fix "show more" button's width to 130 pixels.

BUG: 271353

M  +3    -1    applet/nmpopup.cpp     

http://commits.kde.org/networkmanagement/56cabdf905f538eede41f6cd9816e369359f640b
Comment 2 Pino Toscano 2011-04-21 00:29:29 UTC 
Fixing the width of a button basing on some arbitrary is simply unacceptable.
Other than breaking on translations, it will break with different font sizes even with the English language. Where is this 130px coming from?

Lamarque, please revert.

(In reply to comment #0)
> And I doubt that any language has a word for “more” that is much longer than
> “less”, in German for example “Weniger anzeigen” is a bit wider than “Mehr
> anzeigen” but it is so annoying that it changes its size.

Assuming things like that about language is *broken*.
Comment 3 Lamarque V. Souza 2011-04-21 05:09:33 UTC 
Git commit c05ac96ee4f9fecde5ba5e6c44d062bc3715f476 by Lamarque V. Souza.
Committed on 21/04/2011 at 05:15.
Pushed by lvsouza into branch 'master'.

Move height setup of all connection widgets to ActivatedItem
constructor. Now all connection widgets have the same height and do not
change it when toggling the "Show More" button.

CCBUG: 271353

M  +5    -1    applet/activatableitem.cpp     
M  +2    -0    applet/activatableitem.h     
M  +0    -5    applet/gsminterfaceconnectionitem.cpp     
M  +0    -4    applet/hiddenwirelessnetworkitem.cpp     
M  +0    -5    applet/interfaceconnectionitem.cpp     
M  +0    -7    applet/wirelessnetworkitem.cpp     

http://commits.kde.org/networkmanagement/c05ac96ee4f9fecde5ba5e6c44d062bc3715f476
Comment 4 Lamarque V. Souza 2011-04-21 05:09:33 UTC 
Git commit 80a7c96836e35529efd83c936a8d40b75b779ff5 by Lamarque V. Souza.
Committed on 21/04/2011 at 05:15.
Pushed by lvsouza into branch 'nm09'.

Move height setup of all connection widgets to ActivatedItem
constructor. Now all connection widgets have the same height and do not
change it when toggling the "Show More" button.

CCBUG: 271353
(cherry picked from commit c05ac96ee4f9fecde5ba5e6c44d062bc3715f476)

M  +5    -1    applet/activatableitem.cpp     
M  +2    -0    applet/activatableitem.h     
M  +0    -5    applet/gsminterfaceconnectionitem.cpp     
M  +0    -4    applet/hiddenwirelessnetworkitem.cpp     
M  +0    -5    applet/interfaceconnectionitem.cpp     
M  +0    -7    applet/wirelessnetworkitem.cpp     

http://commits.kde.org/networkmanagement/80a7c96836e35529efd83c936a8d40b75b779ff5
Comment 5 Lamarque V. Souza 2011-04-24 05:40:10 UTC 
Git commit d2f2a447b1e3060c3a5236caaea0bad9c1eb9d47 by Lamarque V. Souza.
Committed on 23/04/2011 at 23:25.
Pushed by lvsouza into branch 'master'.

Try to fix side effects of comit
c05ac96ee4f9fecde5ba5e6c44d062bc3715f476 (Move height setup of all
connection widgets to ActivatedItem constructor. Now all connection
widgets have the same height and do not change it when toggling the
"Show More" button)

CCBUG: 271491
CCBUG: 271353

M  +1    -1    applet/activatableitem.cpp     
M  +1    -1    applet/activatablelistwidget.cpp     
M  +2    -2    applet/gsminterfaceconnectionitem.cpp     
M  +2    -2    applet/wirelessnetworkitem.cpp     

http://commits.kde.org/networkmanagement/d2f2a447b1e3060c3a5236caaea0bad9c1eb9d47
Comment 6 Lamarque V. Souza 2011-04-24 05:41:08 UTC 
Git commit d7abc1f1eec401fb1d920c7b864b47e973170122 by Lamarque V. Souza.
Committed on 23/04/2011 at 23:25.
Pushed by lvsouza into branch 'nm09'.

Try to fix side effects of comit
c05ac96ee4f9fecde5ba5e6c44d062bc3715f476 (Move height setup of all
connection widgets to ActivatedItem constructor. Now all connection
widgets have the same height and do not change it when toggling the
"Show More" button)

CCBUG: 271491
CCBUG: 271353
(cherry picked from commit d2f2a447b1e3060c3a5236caaea0bad9c1eb9d47)

M  +1    -1    applet/activatableitem.cpp     
M  +1    -1    applet/activatablelistwidget.cpp     
M  +2    -2    applet/gsminterfaceconnectionitem.cpp     
M  +2    -2    applet/wirelessnetworkitem.cpp     

http://commits.kde.org/networkmanagement/d7abc1f1eec401fb1d920c7b864b47e973170122