Summary: | Modifying transactions with spaces in their amounts causes them to be reset to 0 | ||
---|---|---|---|
Product: | [Applications] skrooge | Reporter: | Harald Hvaal <metellius> |
Component: | general | Assignee: | Stephane MANKOWSKI <stephane> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | metellius, stephane |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Screenshot of application. |
Description
Harald Hvaal
2011-04-19 14:16:44 UTC
Hi, I tried to reproduce the problem but I am not able. Could you give me more information ? What is your skrooge version ? What is your locale (Norwegian) ? Could you send me a screen capture ? My environment locale: harald@kozue:~$ locale LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_PAPER="en_US.UTF-8" LC_NAME="en_US.UTF-8" LC_ADDRESS="en_US.UTF-8" LC_TELEPHONE="en_US.UTF-8" LC_MEASUREMENT="en_US.UTF-8" LC_IDENTIFICATION="en_US.UTF-8" LC_ALL= ...but in KDE locale settings, "Country or region" is set to Norway. I tried to set these locale settings to United States of America, and then do the following: - add new dummy account - add new transaction, amount 9999USD (in the amount field, this is now formatted as "+ 9,999.00") - deselect, select transation in operations view - click amount field - click Modify (amount of operation was now set to 0) Now, when I tried this with US locale, it did not always happen, and I haven't completely figured out when yet. It seems the regional setting "Thousands separator" in the KDE locale settings might have an influence. Right now it's late and due to lack of time more debugging will have to wait a day or two. Hi, I formatted my currency like you "+ 9,999.00" but I am still not able to reproduce the problem. Could you confirm that you are using Skrooge 0.8.0 at least ? Could you launch Skrooge from a console and tell me if you have a trace like this when you are able to reproduce the error ? WARNING: SKGServices::stringToDouble(xxx) failed If yes, could tell me what is the value of xxx in your case ? Created attachment 59180 [details]
Screenshot of application.
Pressing modify in the attached screenshot will reset the amount to 0.
(In reply to comment #3) > Could you confirm that you are using Skrooge 0.8.0 at least ? Yes, I am using 0.8.1. (In reply to comment #4) > If yes, could tell me what is the value of xxx in your case ? Indeed, I am getting: ##WARNING: SKGServices::stringToDouble(+ 9 999,00) failed Git commit 5c5b59711308c1f6663cdec9422b135ccbbeb5d2 by Stephane Mankowski. Committed on 21/04/2011 at 21:51. Pushed by smankowski into branch 'master'. BUG: 271294: Modifying transactions with spaces in their amounts causes them to be reset to 0 M +1 -0 CHANGELOG M +9 -1 skgbasegui/skgcalculatoredit.cpp M +11 -0 skgbasegui/skgcalculatoredit.h M +2 -0 skrooge_operation/skgoperationpluginwidget.cpp http://commits.kde.org/skrooge/5c5b59711308c1f6663cdec9422b135ccbbeb5d2 Sorry, but this bug is still there, running 0.9.0 I have a transaction for 15 000 NOK, and I select it and press Modify, and it instantly changes to 0. As before, I am getting in the console: ##WARNING: SKGServices::stringToDouble(+ 15 000,00) failed ##WARNING: SKGServices::stringToDouble(+ 15 000,00) failed (yes, twice) Note, I am seeing the same thing also when changing the name for a bank account; the initial balance goes to 0. Git commit 2ee57c4aaa944a3aeadb754d20f1d5ba2c6e5638 by Stephane Mankowski. Committed on 28/07/2011 at 21:04. Pushed by smankowski into branch 'Feature'. BUG: 271294: Modifying transactions with spaces in their amounts causes them to be reset to 0 M +34 -18 plugins/skrooge/skrooge_bank/skgbankpluginwidget_base.ui M +1 -1 plugins/skrooge/skrooge_unit/skgunitpluginwidget.cpp M +1 -1 CHANGELOG M +2 -1 skgbasegui/skgcalculatoredit.h M +29 -15 skgbasegui/skgcalculatoredit.cpp M +30 -14 plugins/skrooge/skrooge_unit/skgunitpluginwidget_base.ui M +2 -1 plugins/skrooge/skrooge_bank/skgbankpluginwidget.cpp http://commits.kde.org/skrooge/2ee57c4aaa944a3aeadb754d20f1d5ba2c6e5638 |