Bug 271289

Summary:	networkmanager backend doesn't build with Network Manager 0.9
Product:	[Unmaintained] solid	Reporter:	Andrea Scarpino <scarpino>
Component:	networkmanagement	Assignee:	Will Stephenson <wstephenson>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arthur
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Andrea Scarpino 2011-04-19 12:59:20 UTC

Version:           unspecified (using KDE 4.6.2) 
OS:                Linux

[ 31%] Building CXX object solid/networkmanager-0.7/CMakeFiles/solid_networkmanager07_static.dir/manager.o
/build/src/kdebase-workspace-4.6.2/solid/networkmanager-0.7/manager.cpp:44:1: warning: unused parameter 'parent' [-Wunused-parameter]                                       
/build/src/kdebase-workspace-4.6.2/solid/networkmanager-0.7/manager.cpp: In member function 'virtual QObject* NMNetworkManager::createNetworkInterface(const QString&)':
/build/src/kdebase-workspace-4.6.2/solid/networkmanager-0.7/manager.cpp:121:14: error: 'DEVICE_TYPE_802_3_ETHERNET' was not declared in this scope
/build/src/kdebase-workspace-4.6.2/solid/networkmanager-0.7/manager.cpp:124:14: error: 'DEVICE_TYPE_802_11_WIRELESS' was not declared in this scope
/build/src/kdebase-workspace-4.6.2/solid/networkmanager-0.7/manager.cpp:127:14: error: 'DEVICE_TYPE_GSM' was not declared in this scope
/build/src/kdebase-workspace-4.6.2/solid/networkmanager-0.7/manager.cpp:130:14: error: 'DEVICE_TYPE_CDMA' was not declared in this scope
make[2]: *** [solid/networkmanager-0.7/CMakeFiles/solid_networkmanager07_static.dir/manager.o] Error 1
make[1]: *** [solid/networkmanager-0.7/CMakeFiles/solid_networkmanager07_static.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....


Reproducible: Always

Steps to Reproduce:
build kdebase-workspace with NM0.9

Actual Results:  
build fails


KDE 4.6.2
networkmanager 0.8.998
gcc 4.6.0

Comment 1 Andrea Scarpino 2011-04-29 14:52:55 UTC

This is a feature request now, kdebase-workspace 4.6.3 avoid to build the NM backend with NM < 0.9

Comment 2 Lamarque V. Souza 2011-05-22 00:07:58 UTC

Git commit e41d904ea853f0af2215bc591802aebc5909606a by Lamarque V. Souza.
Committed on 20/05/2011 at 21:14.
Pushed by lvsouza into branch 'master'.

Marking Solid's NetworkManager backend to compile only if NM-0.7 or
0.8 headers are installed. The NM-0.9 backend is in
git://anongit.kde.org/networkmanagement/solidcontrolfuture (nm09 branch)
now and is automatically compiled/installed when building Plasma NM.
When it is ready we are going to move the backend back to kde-workspace.
The networkmanager-0.7 backend supports and will only support 0.7
and 0.8 versions of NetworkManager.

BUG: 271289

M  +1    -1    solid/CMakeLists.txt     

http://commits.kde.org/kde-workspace/e41d904ea853f0af2215bc591802aebc5909606a

Comment 3 Lamarque V. Souza 2011-05-22 00:10:12 UTC

Git commit a5b17b11bae0f2a1a263b5869541a25d6f0ae430 by Lamarque V. Souza.
Committed on 20/05/2011 at 21:14.
Pushed by lvsouza into branch 'KDE/4.6'.

Marking Solid's NetworkManager backend to compile only if NM-0.7 or
0.8 headers are installed. The NM-0.9 backend is in
git://anongit.kde.org/networkmanagement/solidcontrolfuture (nm09 branch)
now and is automatically compiled/installed when building Plasma NM.
When it is ready we are going to move the backend back to kde-workspace.
The networkmanager-0.7 backend supports and will only support 0.7
and 0.8 versions of NetworkManager.

BUG: 271289

M  +1    -1    solid/CMakeLists.txt     

http://commits.kde.org/kde-workspace/a5b17b11bae0f2a1a263b5869541a25d6f0ae430