Bug 270677

Summary:	Submitting a patch to reviewboard does not work
Product:	[Applications] kdevelop	Reporter:	Frederik Gladhorn <gladhorn>
Component:	general	Assignee:	Aleix Pol <aleixpol>
Status:	RESOLVED FIXED
Severity:	normal	CC:	david.narvaez, j_kolberg11
Priority:	NOR
Version:	4.2.1
Target Milestone:	4.2.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Frederik Gladhorn 2011-04-11 12:36:13 UTC

Version:           4.2.1 (using KDE 4.6.2) 
OS:                Linux

When using the git diff view, I should be able to upload a diff to reviewboard.

Reproducible: Didn't try

Steps to Reproduce:
Use the Git... menu to get to the diff view, use the Export Diff... button, choose reviewboard.
The dialog always fails.

Comment 1 Jonathan Kolberg 2011-06-26 14:33:52 UTC

That’s right. I guess the problem is that the plugin doesn’t set a group for the review, so reviewboard won’t let you create a review.

I hope that helps to fix this.

Comment 2 David E. Narvaez 2011-10-06 11:53:57 UTC

Git commit ab67a27a00a3550ee4f976128648571f0b1c0046 by David E. Narváez.
Committed on 06/10/2011 at 13:49.
Pushed by narvaez into branch 'master'.

Listing Repos with Reviewboard API 2.0

Changed the workflow for requesting the list of repositories according
to API 2.0 specification.
CCBUG: 270677
REVIEW: 102789

M  +29   -8    plugins/reviewboard/reviewboardjobs.cpp
M  +7    -2    plugins/reviewboard/reviewboardjobs.h

http://commits.kde.org/kdevplatform/ab67a27a00a3550ee4f976128648571f0b1c0046

Comment 3 David E. Narvaez 2011-10-06 11:57:46 UTC

Just to clarify, by the time this bug was originally reported, Reviewboard plugin used not to work, but it was then fixed in KDevPlatform for a while until there was an API change at KDE's Reviewboard which broke it again. My lat commit fixes the situation with the new API so I can confirm it's working now on master.