| Summary: | build fails - getdomainname | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | tropikhajma <tropikhajma> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | git master | ||
| Target Milestone: | 4.11 | ||
| Platform: | Compiled Sources | ||
| OS: | Solaris | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/cbb7f5750fe2a3b4916a00a648efe71f51af3b77 | Version Fixed In: | 4.11 |
| Sentry Crash Report: | |||
| Attachments: | patch | ||
The ifdef looks like a non-proper fix. There is no else part. Could you please take the patch to reviewboard as it is easier to discuss patches there. Thanks. Is this still an issue? |
Created attachment 58764 [details] patch Version: SVN (using KDE 4.6.2) OS: Solaris build on solaris fails with the below error. Attached patch fixes the issue the same way it's already handled in kdm/kfrontend/themer/kdmlabel.cpp ... test@kdezone:~/packages/BUILD/kdebase-workspace-4.6.2/build-kdebase-workspace-4.6.2/kwin$ cd /home/test/packages/BUILD/kdebase-workspace-4.6.2/build-kdebase-workspace-4.6.2/kwin && /opt/sunstudio12.1/bin/CC -Dkdeinit_kwin_EXPORTS -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS -DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=25 -DHAVE_CONFIG_H=1 -DDISABLE_NEPOMUK_LEGACY -D__EXTENSIONS__ -DSOLARIS -D_REENTRANT -DNDEBUG -D__EXTENSIONS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_POSIX_PTHREAD_SEMANTICS -DSOLARIS -DSOLARIS10 -DNO_DEBUG -D_UNICODE -DUNICODE -D_RWSTD_REENTRANT -D_XOPEN_SOURCE=500 -D_XPG5 -I/usr/include/stdcxx4/ansi -I/usr/include/stdcxx4 -I/opt/kde4/include -Usun -I/usr/include/stdcxx4/ansi -I/usr/include/stdcxx4 -library=no%Cstd -library=Crun -features=anachronisms,except,rtti,export,extensions,nestedaccess,tmplife,tmplrefstatic -instances=global -template=geninlinefuncs -s -xdebugformat=dwarf -xlang=c99 -xalias_level=compatible -xustr=ascii_utf16_ushort -Qoption ccfe -features=gcc -Qoption ccfe -features=zla -Qoption ccfe ++boolflag:sunwcch=false -mt -xF=%none -xbuiltin=%all -xinline=%auto -xprefetch=auto -xprefetch_auto_type=indirect_array_access -xprefetch_level=3 -xalias_level=compatible -KPIC -DPIC -xipo=0 -xO3 -xregs=no%frameptr -xjobs=2 -xrestrict=%all -xthreadvar=%all -z combreloc -z redlocsym -z nodefaultlib -z ignore -z now -z rescan -z absexec -xldscope=symbolic -xlibmil -s -xtarget=pentium4 -m32 -xarch=sse2 -xchip=pentium4 -xcache=8/64/4:256/128/8 -lc -lm -ldl -lpthread -lposix4 -lrt -mt -Y P,/opt/kde4/lib -i -L/opt/kde4/lib -R/opt/kde4/lib -L/usr/lib -R/usr/lib -Bdynamic -lstdcxx4 -lCrun -lc -lm -g -xO3 -DQT_NO_DEBUG -KPIC -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/build-kdebase-workspace-4.6.2/kwin -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin -I/home/test/packages/BUILD/kdebase-workspace-4.6.2 -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/build-kdebase-workspace-4.6.2 -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/kdm -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/libs -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/libs/kworkspace -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/build-kdebase-workspace-4.6.2/kwin/lib -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/lib -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/effects -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/tabbox -I/home/test/packages/BUILD/kdebase-workspace-4.6.2/libs/kephal -I/opt/kde4/include -I/opt/kde4/include/KDE -I/opt/kde4/include/QtXmlPatterns -I/opt/kde4/include/QtXml -I/opt/kde4/include/QtWebKit -I/opt/kde4/include/QtUiTools -I/opt/kde4/include/QtTest -I/opt/kde4/include/QtSvg -I/opt/kde4/include/QtSql -I/opt/kde4/include/QtScriptTools -I/opt/kde4/include/QtScript -I/opt/kde4/include/QtOpenGL -I/opt/kde4/include/QtNetwork -I/opt/kde4/include/QtMultimedia -I/opt/kde4/include/QtHelp -I/opt/kde4/include/QtDesigner -I/opt/kde4/include/QtDeclarative -I/opt/kde4/include/QtDBus -I/opt/kde4/include/Qt3Support -I/opt/kde4/include/QtGui -I/opt/kde4/include/QtCore -I/opt/kde4/include/Qt -I/opt/kde4/share/mkspecs/default -I/usr/X11/include -D_LARGEFILE64_SOURCE -o CMakeFiles/kdeinit_kwin.dir/utils.o -c /home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/utils.cpp "/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/utils.cpp", line 270: Warning (Anachronism): Formal argument 3 of type extern "C" int(*)(_XDisplay*,_XEvent*,char*) in call to XCheckIfEvent(_XDisplay*, _XEvent*, extern "C" int(*)(_XDisplay*,_XEvent*,char*), char*) is being passed int(*)(_XDisplay*,_XEvent*,char*). "/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/utils.cpp", line 274: Warning (Anachronism): Formal argument 3 of type extern "C" int(*)(_XDisplay*,_XEvent*,char*) in call to XCheckIfEvent(_XDisplay*, _XEvent*, extern "C" int(*)(_XDisplay*,_XEvent*,char*), char*) is being passed int(*)(_XDisplay*,_XEvent*,char*). "/home/test/packages/BUILD/kdebase-workspace-4.6.2/kwin/utils.cpp", line 441: Error: The function "getdomainname" must have a prototype. 1 Error(s) and 2 Warning(s) detected. Reproducible: Always