| Summary: | UltimateGuitar reporting an unauthorized application, not loading tab | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Chaim Kirby <misthop> |
| Component: | Context View/Tabs | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kfunk, rainer.sigle, sam |
| Priority: | NOR | Keywords: | regression |
| Version: | 2.4.0 | ||
| Target Milestone: | 2.4.1 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.4.2 | |
| Sentry Crash Report: | |||
|
Description
Chaim Kirby
2011-04-08 14:53:52 UTC
Rainer, could you please have a look at this ASAP? The actual tab should be present below the warning message. All they've done is put the warning message before the tabs themselves, with the warning message hidden with CSS so it's invisible in a web browser. There's absolutely nothing intelligent about what they've done. 'Fixing' should simply be a case of ignoring the first <pre></pre> tag located on the page and displaying the second. Sorry, I'havent seen that report earlier. It really seems that that we're violating the terms of use from ultimateguitar.com. I was absolutely not aware of that, when I've implemented the applet. So, if that's really the case the highest priority is to respect law and protect Amarok. Although it would be easy, I'll definitly not remove the warning message by purpose. Unless we find an agreement with the site, which I doubt they will agree (and I've also no contact with them), I think we should disable the applet. What do you think? Myriam: Should this be discussed on the devel mailing list? My thoughts: http://www.ultimate-guitar.com/about/tos.htm (relevant part seems to be section 16) I don't see that we're violating the terms there. Furthermore, the warning displayed on the tabs refers specifically to iPhone/Android applications, which we are not. Section 16 provides an email address to contact if you want to use their content for commercial purposes. I suppose if others are more concerned about the terms here than I am, someone could contact that address. I've sent an e-mail to Ultimate-Guitar asking for using their service in a non-commercial application. Now looking forward to hearing from them and reporting here afterwards... Rainer: yes, please take this to the amarok-devel@ mailing list, as it is important everybody knows about. This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. The bug has been partially fixed. The warning still shows up, but after the warning the tab shows as expected. Yes, the warning message is stell present. I tried to contact Ultimate Guitar two times already, but no reaction each time. At least they created a case, but it was closed a few days later with not a single response. I've a one-liner fix in place. Should I commit it? If it's not an really ugly hack, do it ;) Else, just join #amarok and discuss. Fixed. commit 1c644792737f308b9e12ffce7fa70f7ab477729e Author: Rainer Sigle <rainer.sigle@web.de> Date: Sun Jun 5 17:16:07 2011 +0200 Remove warning message from UltimateGuitar. BUG:270440 FIXED-IN: 2.4.2 |