Bug 270435

Summary:	Dolphin should not clear selection when deactivating preview
Product:	[Applications] dolphin	Reporter:	Alvaro Manuel Recio Perez <amrecio>
Component:	general	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	minor	CC:	frank78ac
Priority:	NOR
Version:	16.12.2
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.7.0
Sentry Crash Report:

Description Alvaro Manuel Recio Perez 2011-04-08 14:01:43 UTC

Version:           unspecified (using KDE 4.6.2) 
OS:                Linux

When some files and or folders are selected and the user clicks the "Preview" button, the selection is kept after the view is updated. However, if the user clicks "Preview" again, to disable it, the selection is cleared.

Dolphin should be consistent in this behaviour and, in my opinion, not clearing the selection is the most appropriate option.

Reproducible: Always

Steps to Reproduce:
1. Open Dolphin and select some files.
2. Click Preview to activate it.
3. Notices that the selection is kept.
4. Click Preview to disable it.

Actual Results:  
The selection is cleared.

Expected Results:  
The selection should not be cleared.

OS: Linux (x86_64) release 2.6.35-28-generic
Compiler: cc

Comment 1 Frank Reininghaus 2011-04-08 20:04:55 UTC

Thanks for the bug report! I can confirm the issue in master.

Comment 2 Peter Penz 2011-04-08 20:24:50 UTC

The issue has the same root cause like bug 270437 - will try to fix it during this week.

Comment 3 Peter Penz 2011-04-08 20:48:45 UTC

Git commit 41854146040f8638fffb13b20a75f6ecda2837a6 by Peter Penz.
Committed on 08/04/2011 at 20:52.
Pushed by ppenz into branch 'master'.

KFilePreviewGenerator: Prevent unnecessary reloading of directory

When turning off previews the reloading of the directory is
unnecessary and has side effects:
- The selection gets cleared
- The position of the view might get reset

BUG: 270437
BUG: 270435
FIXED-IN: 4.7.0

M  +17   -13   kfile/kfilepreviewgenerator.cpp     

http://commits.kde.org/kdelibs/41854146040f8638fffb13b20a75f6ecda2837a6