| Summary: | knotify in kdebase-runtime installs headers (against policy) | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | Benjamin Reed <ranger> |
| Component: | knotify | Assignee: | Olivier Goffart <ogoffart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | christoph, j.maceachern |
| Priority: | NOR | ||
| Version: | 4.6 | ||
| Target Milestone: | --- | ||
| Platform: | Fink Packages | ||
| OS: | macOS | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
My apologies, I didn't take care of that properly. I'm currently coming up on exams, so I won't be able to fix it for the moment. I think that is fixed in frameworks. |
Version: 4.6 (using KDE 4.6.1) OS: OS X the knotifyplugin library in kdebase-runtime has 2 issues which are making it problematic to package: 1. kdebase-runtime is supposed to contain no libraries other than private ones, and should install no headers 2. the knotifyplugin library is built without a version number, which gives it the name "knotifyplugin.dylib" on OSX, with a "current_version" of 0.0.0. 0-versioned libraries on OSX are special cases and not treated like properly-versioned libraries when it comes to complaining about ABI and compatibility issues. knotifyplugin should, I presume, move to kdelibs, where other public libraries with headers go. Additionally, as a public library, I would assume it should get the default versioning, like other libraries in kdelibs: kde4_add_library( knotifyplugin SHARED ${knotifyplugin_SRCS}) + + set_target_properties( knotifyplugin PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION ${GENERIC_LIB_SOVERSION}) Reproducible: Always Steps to Reproduce: compile kdebase-runtime 4.6.1 Actual Results: unversioned library is built, and headers are installed Expected Results: kdebase-runtime should contain only runtime plugins, binaries, and private libraries (and supporting files)