Bug 269344

Summary:	untranslated strings due to missing i18n/tr calls
Product:	[Applications] marble	Reporter:	Burkhard Lück <lueck>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	normal	CC:	aspotashev, nienhueser
Priority:	NOR
Version:	unspecified
Target Milestone:	1.1.0
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch to fix the bug patch with more i18n/tr calls

Description Burkhard Lück 2011-03-24 21:18:38 UTC

Version:           unspecified (using Devel) 
OS:                Linux

bug is in trunk + branch

Reproducible: Always

Comment 1 Burkhard Lück 2011-03-24 21:19:32 UTC

Created attachment 58313 [details]
patch to fix the bug

Comment 2 Dennis Nienhüser 2011-03-26 10:50:39 UTC

Looks good, can you commit it?

I think that in marble_part.cpp, line 1050 we need another i18n() call in front of DATETIME_STRING:

QString templateDateTimeString = QString( "%1 %2" ).arg( i18n( DATETIME_STRING ), QLocale().toString( QDateTime::fromString ( "01:01:1000", "dd:mm:yyyy"), QLocale::ShortFormat ) );

Comment 3 Burkhard Lück 2011-03-26 17:45:50 UTC

(In reply to comment #2)
> Looks good, can you commit it?
> 
Yes. with some additional i18n calls to get "Position: not available" translated when the mouse pointer is outside the map or before the first mouse move.

> I think that in marble_part.cpp, line 1050 we need another i18n() call in front of DATETIME_STRING:
> 
In theory you are right (and there had to be two more i18n(POSITION_STRING) and i18n(DISTANCE_STRING)).
But it does not matter to have the strings untranslated here, updateStatusBar is immediately called after setupStatusBar, so our user will never notice these untranslated strings.

Comment 4 Burkhard Lück 2011-03-26 17:46:50 UTC

Created attachment 58361 [details]
patch with more i18n/tr calls

Comment 5 Burkhard Lück 2011-05-07 11:09:27 UTC

Any bjections to fix this bug with the patch  http://bugsfiles.kde.org/attachment.cgi?id=58361 in master + branch?

Comment 6 Dennis Nienhüser 2011-05-07 18:13:56 UTC

Sorry for the delay. Patch looks good, please commit.

Comment 7 Burkhard Lück 2011-05-09 22:07:50 UTC

Git commit dffb2ec8e5f0126e60268ce401ff00e1ca1914a7 by Burkhard Lück.
Committed on 09/05/2011 at 14:22.
Pushed by lueck into branch 'kde-4.6'.

add missing i18n()/tr() calls to make strings translatable
CCBUG:269344
(cherry picked from commit 00db0c1f85e04e954a0353ae6d67fbcdee1df8af)

M  +3    -3    src/lib/routing/RoutingInputWidget.cpp     
M  +5    -5    src/marble_part.cpp     

http://commits.kde.org/marble/dffb2ec8e5f0126e60268ce401ff00e1ca1914a7

Comment 8 Burkhard Lück 2011-05-09 22:07:50 UTC

Git commit 00db0c1f85e04e954a0353ae6d67fbcdee1df8af by Burkhard Lück.
Committed on 09/05/2011 at 14:22.
Pushed by lueck into branch 'master'.

add missing i18n()/tr() calls to make strings translatable
BUG:269344

M  +3    -3    src/lib/routing/RoutingInputWidget.cpp     
M  +5    -5    src/marble_part.cpp     

http://commits.kde.org/marble/00db0c1f85e04e954a0353ae6d67fbcdee1df8af