| Summary: | [Patch] kdeedu-marble doesn't build with gpsd 2.96 | ||
|---|---|---|---|
| Product: | [Applications] marble | Reporter: | Andrea Scarpino <scarpino> |
| Component: | general | Assignee: | marble-bugs |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aspotashev, cfeck, dilfridge, ismail, meyerm, mgmadden, nienhueser, rdieter, vbatts |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | 1.0 (KDE 4.6) | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.2.2 (KDE 4.7.2) | |
| Sentry Crash Report: | |||
| Attachments: |
marble patch, to accomodate for the sillyness in gpsd-2.96
buildfix against gpsd-3.0 |
||
|
Description
Andrea Scarpino
2011-03-22 18:53:53 UTC
Created attachment 58819 [details]
marble patch, to accomodate for the sillyness in gpsd-2.96
I've confirmed the same issue on KDE-4.5.5. The gpsd version 2.95 works just fine. That project made some fundamental changes in the version bump to version 2.96, like straight removing the open() member of the gpsmm class and a couple of other such things. Attached is a patch that should apply to 4.6.1 and newer, and still allow gpsd 2.95 to compile. Hey Vincent, thanks for the patch. I'll try to get a hold on gpsd 2.96 and test it. These API changes are cumbersome. Hi Vincent, I applied your patch to marble 4.6.2, but it doesn't work. When I choice gpsd under "Position Tracking" I get: "Error when determining current location: Unknown error when opening gpsd connection". Using xgps or qlandkartegt everything work. KDE 4.6.2 kdeedu-marble 4.6.2 gpsd 2.96 Still valid for marble-4.6.4 still valid for 4.6.5 When is this problem going away ?????? This is frustrating indeed. These API changes make it difficult to work around. It is tempting to set a sticky dependency on the 2.95 version of gpsd, because they've stated in their goals, that the API will continue to change in drastic ways as they approach 3.0 I've put 5-10hrs into working on a patch for this, and still have nothing good to show for it. I even tried working with the gps.h, instead of their C++ implementation. Same results. Anyone else one to try their hand at a fix? Hi Vincent,I can confirm that the problem has been fixed as far as 4.7.0 is concerned,on Gentoo. Previously I had applied tha patch,with modded headers to versions 4.6.2 4.6.3 & 4.6.4 all successful,I automatically applied the patch to 4.7.0 which complained and fell over. By removing the patch from the files dir and doing a resync and recompile no problems,I dont specifically call gpsd nor do I use position reporting under Marble,It is used by Xastir but there are no problems with the running of this program (In reply to comment #8) > Hi Vincent,I can confirm that the problem has been fixed as far as 4.7.0 is > concerned,on Gentoo. No. Gentoo kde team here. The patch should not have been applied in Gentoo, that was an oversight. It only fixes compilation, but the resulting binary does not work properly with gpsd-2.96. :( besides having hot-new-stuff, is there a particular reason to move to gpsd-2.96? (In reply to comment #10) > besides having hot-new-stuff, is there a particular reason to move to > gpsd-2.96? In Arch Linux we already are using the 3.0 released some day ago with systemd support[1] [1] http://lists.berlios.de/pipermail/gpsd-dev/2011-April/009309.html WOOT. Let me get to testing this. I'll post back here shortly. (In reply to comment #12) > WOOT. Let me get to testing this. I'll post back here shortly. I'm having trouble getting this patch/diff from comment10 to do anything. do you know which files it refers to ?? ,I'm currently trying it on gpsd-2.96 from my mirror, or is it a case of retrieving version 3 from git Geoff confirmed patch works as advertised, attaching one that applies against master/kde-4.7 Created attachment 63128 [details]
buildfix against gpsd-3.0
Buildfix is fine but does it actually work? Did anyone test on a machine with GPS? Patch fails to apply on master. Git commit 9aa0e1e73301ec58210988732de78f17798dc1ef by Dennis Nienhüser. Committed on 17/09/2011 at 13:54. Pushed by nienhueser into branch 'master'. Support gpsd 2.96 and 3.1. Patch based on Vincent Batts patch submitted in bug 269165, thanks! Tested with gpsd 2.96 (berlios tarball), gpsd 3.1 (berlios tarball) and 2.95 (ubuntu package). BUG: 269165 M +15 -1 src/plugins/positionprovider/gpsd/GpsdConnection.cpp http://commits.kde.org/marble/9aa0e1e73301ec58210988732de78f17798dc1ef Git commit 7fd1dd92e421ca6e0b8755a9aa2e47b5fa8c3ac0 by Dennis Nienhüser. Committed on 17/09/2011 at 13:54. Pushed by nienhueser into branch 'kde-4.7'. Support gpsd 2.96 and 3.1. Patch based on Vincent Batts patch submitted in bug 269165, thanks! Tested with gpsd 2.96 (berlios tarball), gpsd 3.1 (berlios tarball) and 2.95 (ubuntu package). CCBUG: 269165 FIXED-IN: KDE-4.7.2/Marble-1.2.2 (cherry picked from commit 9aa0e1e73301ec58210988732de78f17798dc1ef) M +15 -1 src/plugins/positionprovider/gpsd/GpsdConnection.cpp http://commits.kde.org/marble/7fd1dd92e421ca6e0b8755a9aa2e47b5fa8c3ac0 |