Bug 268329

Summary: Labels (rating, color, pick) in slideshow not alway shown correctly/sometimes forgotten
Product: [Applications] digikam Reporter: Bastiaan Hovestreydt <bko>
Component: Tags-ColorsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 2.0.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 7.6.0
Sentry Crash Report:

Description Bastiaan Hovestreydt 2011-03-12 23:54:26 UTC 
Version:           2.0.0 (using KDE 4.6.1) 
OS:                Linux



Reproducible: Always

Steps to Reproduce:
-start a slideshow
-rate, pick or assign a color to an image using the optional controls in the lower left corner
-forward or back in the slideshow
-go back to the image you changed


Actual Results:  
The the rating, color and pick is not shown anymore. The rating however is the only thing that is actually preserved. The color and pick information is reset as soon as you revisit the image in the slideshow.

Expected Results:  
The controls in the lower left corner show the changes made when viewing the image the first time and these changes always get saved.
Comment 1 caulier.gilles 2011-03-13 11:56:51 UTC 
Bastian,

Do you run slideshow from image editor ? If yes, i can reproduce it, else from another part, no (as iconview or light table)

In Image Editor, i also seen than when you change color/pick labels from Caption and tags sidebar, the information is not registered properly. Look result in Imageproperties sidebar, on the bottom.

But if you changes color or pick label, AND rating, in this case, all work fine.

Conclusion : with color and pick labels, a signal is not emitted to DB to register properties, as it's done with rating. 

Marcel, Andi, can you confirm this ?

Gilles Caulier
Comment 2 Bastiaan Hovestreydt 2011-03-13 15:43:03 UTC 
Hi Gilles,

I originally tried it from the thumbnail view but I just tried starting the slideshow from image editor and it behaves exactly the same. The changed rating, color and pick label is not displayed in slideshow if I go back to an image. It always reverts back to the state the labels where whens starting the slideshow. This all happens in the same slideshow: I start it once, change labels on an image and the go back and forth.
When I return to the thumbnail view I find all ratings I've set, however the color and pick labels of images I've seen twice in slideshow are unchanged.
I have no problem with rating and labeling images in the thumbnail viewer, they are always shown correctly within the slideshow.

Bastiaan
Comment 3 Marcel Wiesweg 2011-03-13 16:57:21 UTC 
Git commit 419727fe4cd31afb12a45e960082de49045275d8 by Marcel Wiesweg.
Committed on 13/03/2011 at 16:31.
Pushed by mwiesweg into branch 'master'.

Listen to tag changes and update the properties tab on change

CCBUG: 268329

M  +27   -0    libs/imageproperties/imagepropertiessidebardb.cpp     
M  +2    -0    libs/imageproperties/imagepropertiessidebardb.h     

http://commits.kde.org/digikam/419727fe4cd31afb12a45e960082de49045275d8
Comment 4 Marcel Wiesweg 2011-03-13 22:36:12 UTC 
Note that my commit was not fixing the original report but a problem that Gilles mentioned in his comment...
Comment 5 caulier.gilles 2011-03-13 22:47:44 UTC 
The original problem is due a to cache mechanism dedicated to slideshow about metadata. This cache is not updated when user change labels. I will fix it.

Gilles Caulier
Comment 6 caulier.gilles 2011-03-14 09:47:06 UTC 
Git commit cdc2759b0ae1490b19d71fff97409010543cab23 by Gilles Caulier.
Committed on 14/03/2011 at 09:45.
Pushed by cgilles into branch 'master'.

update slideshow metadata cache if labels info are changed.
BUGS: 268329

M  +3    -0    utilities/slideshow/slideshow.cpp     

http://commits.kde.org/digikam/cdc2759b0ae1490b19d71fff97409010543cab23