| Summary: | Please update Finnish holidays | ||
|---|---|---|---|
| Product: | [Applications] kdepimlibs | Reporter: | Lasse Liehu <lasse.liehu> |
| Component: | kholidays | Assignee: | David E. Narvaez <david.narvaez> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | david.narvaez, jlayt |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdepimlibs/dead9348b739706c89bb44a4654e52c47917a7a4 | Version Fixed In: | 4.9.4 |
| Sentry Crash Report: | |||
| Attachments: |
Updated holiday_fi_fi
Updated holiday_fi_fi with comments Fixed holiday_fi_fi |
||
Hi Lasse, thanks for the update. Could I just ask if you can provide informal English translations of the holiday names as inline comments? It would make my job easier when I make file format changes in the future. Thanks! Created attachment 59017 [details] Updated holiday_fi_fi with comments Sure. I got the "translations" from: 1. almanakka.helsinki.fi 2. Finnish/English Wikipedia 3. http://www.finnguide.fi/calendar (not sure if this is ok) in this order of preference. I also moved some to categories (not entirely sure if they're okay and there's still work to be done there but anyway). Also the comment about Annunciation. Created attachment 64686 [details]
Fixed holiday_fi_fi
Fixed the problems (syntax, formatting, calculating Annunciation) in the latest attachment. Also everything but Leap Day is now categorised. It's done.
Any update on this? Are there still problems with the file? Thanks. Git commit dead9348b739706c89bb44a4654e52c47917a7a4 by David E. Narváez. Committed on 29/11/2012 at 03:27. Pushed by narvaez into branch 'KDE/4.9'. Updating Finnish holidays FIXED-IN: 4.9.4 M +124 -79 kholidays/holidays/plan2/holiday_fi_fi http://commits.kde.org/kdepimlibs/dead9348b739706c89bb44a4654e52c47917a7a4 |
Created attachment 57745 [details] Updated holiday_fi_fi Version: unspecified OS: Linux I've updated the Finnish holidays file (kdepimlibs/kholidays/holidays/plan2/holiday_fi_fi). I've also contacted the original author and the source and both are okay. I've basically: * corrected a few of them ("Laskiaistiistai", Karkauspäivä/Leap Day) * tried to categorize them a bit (couldn't do better) * added some missing days, mostly flag or otherwise notable days Reproducible: Didn't try