Bug 267777

Summary:	Versioning not working properly when saving changes in the image editor
Product:	[Applications] digikam	Reporter:	Andi Clemens <andi.clemens>
Component:	ImageEditor-Versioning	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, veaceslav.munteanu90
Priority:	NOR
Version:	2.5.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	2.6.0
Sentry Crash Report:
Bug Depends on:	287772
Bug Blocks:

Description Andi Clemens 2011-03-06 12:28:48 UTC

Version:           2.0.0 (using KDE 4.6.0) 
OS:                Linux

Saving changes doesn't seem to work at all when closing the image editor and choosing "Save as new version" from the popup dialog.

Choosing "Save changes" closes the editor, but it seems to create a new version (although I didn't want to). When I edit the new version of the image, a "Save changes" results in overwriting the versioned image (as expected).

Reproducible: Always

Steps to Reproduce:
1. Edit an image
2. Make some changes
3. Close the editor
4. Select "Save as new version"

Actual Results:  
Nothing happens, the editor doesn't close

Expected Results:  
Editor closes, a new version has been created for the edited image

OS: Linux (i686) release 2.6.37-ARCH
Compiler: gcc

Comment 1 caulier.gilles 2011-12-13 14:05:37 UTC

Andi,

It still valid with 2.4 ?

Gilles Caulier

Comment 2 Andi Clemens 2011-12-13 19:17:50 UTC

I can't compile digiKam at the moment, since it (or Qt) is not working with the new boost libraries. I will check this when I'm able to compile again.

Comment 3 Andi Clemens 2011-12-21 00:26:05 UTC

I downgraded boost for now to be able to compile digiKam again.
It seems to be fixed now, I couldn't reproduce it.

Comment 4 caulier.gilles 2011-12-21 07:13:35 UTC

Downgraded to which version exactly ?

Gilles Caulier

Comment 5 Andi Clemens 2011-12-21 09:39:15 UTC

I downgraded boost from 1.48.0 to 1.47.0

Comment 6 caulier.gilles 2012-01-04 08:54:46 UTC

Andi,

This entry depend of bug 287772

Gilles Caulier

Comment 7 caulier.gilles 2012-01-04 22:05:02 UTC

Andi,

A developer have posted a patch to support boost 1.48 in the file :

https://bugs.kde.org/attachment.cgi?id=67460

Please, can you take a look if it compile fine on your computer and if versioning work fine with this patch ?

Thanks in advance

Gilles Caulier

Comment 8 caulier.gilles 2012-01-05 11:42:02 UTC

Andi,

patch have been updated to work with all boost version :

http://bugs.kde.org/attachment.cgi?id=67481

It work for you ?

Gilles Caulier

Comment 9 caulier.gilles 2012-01-06 10:26:51 UTC

Git commit d18ea6da2d3e2359f4113e83c3fd40c18a29ddab by Gilles Caulier.
Committed on 06/01/2012 at 11:23.
Pushed by cgilles into branch 'master'.

Apply patch #67483 from Jeremiah Willcock to compile fine digiKam boost graph interface with libboost 1.48
Related: bug 287772

M  +10   -8    libs/database/imagehistory/imagehistorygraph_boost.h

http://commits.kde.org/digikam/d18ea6da2d3e2359f4113e83c3fd40c18a29ddab

Comment 10 caulier.gilles 2012-01-06 10:29:43 UTC

Andi,

I apply patch from bug 287772 about boost compilation failure.

Please check if this entry still valid using current git/master implementation

Thanks in advance

Gilles Caulier

Comment 11 caulier.gilles 2012-01-06 10:34:00 UTC

Andi,

Note, all work fine for me with patch applied, using boost 1.46. I don't have boost 1.47 and 1.48 to check versioning feature from image editor.

Gilles Caulier

Comment 12 Veaceslav Munteanu 2012-01-06 11:51:21 UTC

I can't reproduce this bug with boost 1.47 or with boost 1.48.

My system is an ArchLinux with latest updates and latest git.

Comment 13 caulier.gilles 2012-01-06 12:12:42 UTC

Thanks for the report. I can close this file now.

Gilles Caulier