Bug 267749

Summary:	Save dialog: (double) clicking on a file should initiate a (cancelable, undoable) overwrite operation without having to click "Save" afterwards
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Frank Steinmetzger <dev+kde>
Component:	Open/save dialogs	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bugseforuns, cfeck, kdelibs-bugs, nate, sender, simonandric5
Priority:	NOR	Keywords:	usability
Version:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Bug Depends on:	102972
Bug Blocks:

Description Frank Steinmetzger 2011-03-05 23:25:41 UTC

Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

The open file dialog opens a file if it is single or double-clicked (depending on the double click setting in Dolphin). But when a file is double-clicked in the save file dialog, the dialog does not proceed with saving the file. Instead the user must initiate that by clicking on [Save] or pressing «Enter».

Reproducible: Always

Steps to Reproduce:
Go to some KDE application and select Save as...
(double) click a file in the dialog to tell the program you want to save the file under this name.

Actual Results:  
The name is entered into the name input field and the field is focused. The user must now perform another click on the [Save] button or press «Enter».

Expected Results:  
The dialog should act as if the [Save] button was clicked as well, because when the user double-clicks a file, it is safe to assume that he means to save the file under that name.

The save dialog of other OSes (Windoze) and toolkits (such as GTK) behave as requested here, so the described behavior would be more consistent both with those as well as with KDE’s own open file dialog.

Comment 1 Christoph Feck 2011-08-06 11:52:45 UTC

Please not. As far as I know this is intended, and shouldn't change. I would be highly confused if it closed the dialog just because I clicked on a file name (I use single click mode).

Comment 2 Frank Steinmetzger 2011-08-06 15:18:05 UTC

And what if single-click people would also have to doubleclick? If some uses single-click mode, I would assume that (s)he knows that selecting a file with one click would also “execute” it.

Comment 3 Christoph Feck 2017-08-01 18:22:37 UTC

*** Bug 382961 has been marked as a duplicate of this bug. ***

Comment 4 Sender 2017-08-08 11:26:57 UTC

(In reply to Christoph Feck from comment #1)
> Please not. As far as I know this is intended, and shouldn't change. I would
> be highly confused if it closed the dialog just because I clicked on a file
> name (I use single click mode).

You will never be confused because the dialog will never just close. You will always still be presented with the 'Confirm overwrite' dialog.

I strongly agree with Frank Steinmetzger and having this implemented would speed up my daily workflow considerably (see for further explanation: https://bugs.kde.org/show_bug.cgi?id=382961).

To reiterate the most important points:
- Requested behavior would make the 'Save As' dialog be consistent with the 'Open' dialog;
- Requested behavior is common in other main DE's. 

Thanks for looking into this.

Comment 5 Nate Graham 2018-04-09 22:14:37 UTC

Agreed: this would be desirable, and should pop up a "Replace X file with this one?" dialog like other platforms do. Would also be nice if a sticky systemwide notification with an Undo button appeared afterwards, just in case you didn't actually read the dialog and accidentally blew up your work.

Comment 6 Nate Graham 2018-04-10 19:30:11 UTC

Can't do this until the file dialog itself handles the overwrite dialog. Once that happens, it's probably safe enough to show it when the file is single or double-clicked (depending on user preference).

Comment 7 Nate Graham 2018-05-10 13:09:08 UTC

This was fixed by https://phabricator.kde.org/D12538. Some individual apps (such as Kate) may still try to handle overwrite themselves; we'll be fixing those soon.