Bug 267731

Summary:	Stars are rendered below horizon
Product:	[Applications] kstars	Reporter:	Alexey Khudiakov <alexey.skladnoy>
Component:	general	Assignee:	Akarsh Simha <akarsh.simha>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexey.skladnoy, mutlaqja
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Alexey Khudiakov 2011-03-05 18:26:31 UTC

Version:           unspecified
OS:                Linux

When opaque horizon is switched star are drawn in strip -1° < z < 0°. I think it's not only stars but they are easiest to spot

Reproducible: Always

Comment 1 Jérôme SONRIER 2012-03-08 00:54:55 UTC

Git commit afb12cf258d6f80dca5bc563d7666e2cb1d358ad by Jérôme SONRIER.
Committed on 08/03/2012 at 01:53.
Pushed by jsonrier into branch 'master'.

Don't show objects which are just below the horizon when ground is opac.
CCMAIL: kstars-devel@kde.org

M  +1    -1    kstars/projections/projector.cpp

http://commits.kde.org/kstars/afb12cf258d6f80dca5bc563d7666e2cb1d358ad

Comment 2 Jérôme SONRIER 2012-03-09 23:19:35 UTC

Git commit ffd9cbacf9b10c2eba6a5fb5c9db07f124011f28 by Jérôme SONRIER.
Committed on 10/03/2012 at 00:05.
Pushed by jsonrier into branch 'master'.

Make sure the ground is the last thing drawn, so nothing will be drawn over it.
This fix bug 267731 (my last commit does not fix it).
CCMAIL: kstars-devel@kde.org

M  +1    -1    kstars/projections/projector.cpp
M  +7    -2    kstars/skycomponents/horizoncomponent.cpp
M  +2    -2    kstars/skycomponents/skymapcomposite.cpp

http://commits.kde.org/kstars/ffd9cbacf9b10c2eba6a5fb5c9db07f124011f28

Comment 3 Alexey Khudiakov 2012-04-03 18:08:43 UTC

I tested fix. Thank you Jerome!