| Summary: | Lensfun doesn't work correctly with compact cameras | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Sergey Salnikov <salsergey> |
| Component: | Plugin-Editor-LensCorrection | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, sven.burmeister |
| Priority: | NOR | ||
| Version: | 2.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8 | Version Fixed In: | 3.0.0 |
| Sentry Crash Report: | |||
| Bug Depends on: | 312764 | ||
| Bug Blocks: | |||
| Attachments: | Photo taken with Canon PowerShot S5 IS | ||
|
Description
Sergey Salnikov
2011-03-04 10:20:30 UTC
Can you provide some image to test here. Gilles Caulier Do you use a shared version of lensfun library or do you use version of Lensfun embeded in digiKam core ? Go to Hellp/Components Info for details. Gilles Caulier Created attachment 57669 [details]
Photo taken with Canon PowerShot S5 IS
The photo attached becomes rounded if I use automatic lens identification. If I turn off automatic identification, I can't select "Standard" lens. I have similar behavior with Canon EOS 60D and EF-S lenses. In this case automatic correction works well. However, if I select camera manually, there are no EF-S lenses in the list. Digikam should use a shared version of lensfun. Help/Components gives no information about lensfun. Well, embeded version is current implementation from svn of lensfun. Please recompile digiKam without to use an external Lensfun, which is really outdated now, and include several and important fixes. Note : Ask to Lensfun team to release a new version of the library soon... Gilles Caulier I can try to recompile digikam. However, it seems to me that the problem isn't connected to lensfun. I have downloaded lensfun from svn about a month ago, so it shouldn't be outdated. Also I have said that in darktable (which uses the same lensfun) lens corrections work well with all images. This bug is long known and a dup of bug 253941 using the internal lensfun version does not make a difference. Git commit 8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8 by Gilles Caulier. Committed on 07/01/2013 at 11:16. Pushed by cgilles into branch 'master'. Apply patch #76254 from Roman I Khimov about lensfun interface which don't mangle cropFactor if it's set. This behaviour was introduced by polish commit bebef401e147a00f859cb81774f8498a0623eee5. With this branch present we always get cropFactor of -1.0 in LensFunFilter::filterImage() and given that lensfun library just uses crop factor of 1 which leads to obviously wrong calculations for cropped cameras. Related: bug 312764, bug 253941, bug 266204, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: rik@osrc.info M +0 -4 libs/dimg/filters/lens/lensfuncameraselector.cpp http://commits.kde.org/digikam/8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8 Git commit 613d004121682d122e9ea7fd9041a7bbc49acb89 by Gilles Caulier. Committed on 07/01/2013 at 11:34. Pushed by cgilles into branch 'master'. Apply patch #76256 from Roman I Khimov to use crop factor from camera, not from lens data. Lens crop factor in DB only tells us which crop factor was used for lens calibration data, but it has nothing to do with shots made on random user's camera. So the default behaviour should be to use camera's crop factor and only fallback to lens data if there in no data present for camera. As "this should not happen" it's appropriate to spit out some debug message in this case. Ref: http://lensfun.berlios.de/manual/el_lens.html Ref: http://lensfun.berlios.de/manual/el_camera.html Related: bug 312766, bug 312764, bug 253941, bug 266204, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: roman@khimov.ru M +2 -1 libs/dimg/filters/lens/lensfuncameraselector.cpp M +1 -1 libs/dimg/filters/lens/lensfuniface.cpp http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89 Git commit 70cf9beaac9996c219f988d8ae74d75dc253c0ad by Gilles Caulier. Committed on 07/01/2013 at 11:39. Pushed by cgilles into branch 'master'. Apply patch #76255 from Roman I Khimov to don't pass crop factor as scale factor to lensfun. Sixth parameter to Initialize() is actually a scale factor which has nothing in common with crop factor. I think it's safe to assume that we want no scaling from lensfun and thus use the value of one. Ref: http://lensfun.berlios.de/manual/structlfModifier.html Related: bug 312765, bug 312764, bug 253941, bug 266204, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: roman@khimov.ru M +1 -1 libs/dimg/filters/lens/lensfunfilter.cpp http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad |