| Summary: | formatter settings crash on invalid mimetypes in .desktop file | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Steffen Ohrendorf <steffen.ohrendorf> |
| Component: | Astyle | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | major | ||
| Priority: | VHI | ||
| Version: | git master | ||
| Target Milestone: | 4.2.0 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
backtrace
valgrind output output of ktraderclient for ISourceFormatter |
||
will have to investigate later... cannot reproduce - what are your exact astyle settings? Bugzilla scheint im Moment Probleme zu haben, ich kann weder kommentieren noch Attachments hinzufügen. Ich kriege einen SIGSEGV wenn ich versuche die Einstellungen vom Formatter aufzurufen, evtl. ist es ein upstream Bug. Qt: 4.7.1 KDE: 4.6.00 (4.6.0) "release 6" kde4-config: 1.0 MfG, Syron give us a backtrace, make sure you have up2date kdevplatform + kdevelop Created attachment 58776 [details]
backtrace
that is supposed to be fixed - please make sure you have up2date kdevplatform + kdevelop installed. also check output of "git remote -v" and verify it's pointing to git.kde.org and not still gitorious. if you can still rreproduce it, please valgrind it. Created attachment 58783 [details]
valgrind output
All git remotes are pointing to anongit.kde.org, master is at HEAD, distribution (openSuSE 11.4) is up-to-date. please output the contents of running this command in a konsole: ktraderclient --servicetype KDevelop/Plugin --constraint "'org.kdevelop.ISourceFormatter' in [X-KDevelop-Interfaces]" Created attachment 58797 [details]
output of ktraderclient for ISourceFormatter
verified I'll fix it in quanta, Dmitry has a patch to prevent this issue in kdevplatform Git commit dc8638034d70052776027e7a34d7caedfd3d1881 by Dmitry Risenberg. Committed on 11/04/2011 at 14:09. Pushed by risenberg into branch 'master'. Check KMimeType::mimeType result for null. The result is null if the argument represents an unknown mimetype. CCBUG: 267124 M +4 -0 shell/settings/sourceformattersettings.cpp http://commits.kde.org/kdevplatform/dc8638034d70052776027e7a34d7caedfd3d1881 Still removes the struct's contents, though the crash disappeared. Astyle settings for C++ (not listed entries are unchecked): =Indentation= - Tabs (4) - Indent: Class, Labels, Namespaces, Preprocessor directives, Switches - Maximum in statement: 40 - Minimum in conditional: Twice current =Other= - Type: Attach, break closing headers - Pad parentheses: Inside only - Add spaces around operators - Pointer alignment: Name Git commit 78c341bae38f85f79ff1906d0081b3d905107fb1 by Dmitry Risenberg. Committed on 11/04/2011 at 23:59. Pushed by risenberg into branch 'master'. Fix peeking in astyle string iterator. BUG: 267124 M +4 -2 formatters/astyle/lib/astyle_stringiterator.cpp http://commits.kde.org/kdevelop/78c341bae38f85f79ff1906d0081b3d905107fb1 |
Version: git master (using KDE 4.6.0) OS: Linux When using the internal AStyle formatter, the content of a struct typedef gets deleted. Examples: struct Foo { ... }; typedef struct { ... } Foo; Reproducible: Always Steps to Reproduce: Write some C++ code, create a struct typedef, reformat source. Actual Results: Struct content deleted. Expected Results: Struct content should be formatted.