Bug 267039

Summary:	Disabled menu items have wrong text color in some color schemes
Product:	[Plasma] Oxygen	Reporter:	Ruslan Kabatsayev <b7.10110111>
Component:	gtk2-engine	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	CLOSED FIXED
Severity:	normal	CC:	b7.10110111, hugo.pereira.da.costa, web
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	White Peach color scheme

Description Ruslan Kabatsayev 2011-02-24 09:57:54 UTC

Version:           unspecified
OS:                Linux



Reproducible: Always

Steps to Reproduce:
Select White Peach color scheme.
Open a menu with disabled items.

Actual Results:  
See this screenshot: http://simplest-image-hosting.net/png-0-snapshot117
"Unread messages" item is disabled, but looks almost the same as enabled.


Expected Results:  
Something like disabled items here (oxygen-qt):
http://simplest-image-hosting.net/png-0-snapshot213
(this is on KDE 4.4, maybe something has changed since then)

Comment 1 Hugo Pereira Da Costa 2011-02-24 10:06:36 UTC

Hello Ruslan,
There is a chance that either
- we don't read the right "color effects" (i.e. from the wrong file)
- we read them right but don't apply them right.

Could you send me (or attach here) the color scheme that you use ? 
(usually in $HOME/.kde/share/apps/color-schemes, or in /usr/share/apps/color-schemes)

Comment 2 Ruslan Kabatsayev 2011-02-24 10:21:51 UTC

Created attachment 57494 [details]
White Peach color scheme

Here it is

Comment 3 Hugo Pereira Da Costa 2011-02-24 10:33:02 UTC

Thanks ! can reproduce. Will debug.

Comment 4 Hugo Pereira Da Costa 2011-02-24 14:15:26 UTC

Git commit c5082736c10cfb436349c899322ff87cdf5f0f1d by Hugo Pereira Da Costa.
Committed on 24/02/2011 at 14:13.
Pushed by hpereiradacosta into branch '1.0'.

Fixed foreground color calculations for inactive and disabled palettes

CCBUG: 267039

M  +6    -4    src/oxygenpalette.cpp     

http://commits.kde.org/oxygen-gtk/c5082736c10cfb436349c899322ff87cdf5f0f1d

Comment 5 Hugo Pereira Da Costa 2011-02-24 14:16:28 UTC

That fixes it.
Please close if confirmed.

Comment 6 Ruslan Kabatsayev 2011-02-24 15:51:49 UTC

Yes, fixed. Thanks.