Bug 266397

Summary: ktorrent plugin UPNP should remember preferred routers
Product: [Applications] ktorrent Reporter: Tom Chiverton <bugs.kde.org>
Component: generalAssignee: Joris Guisson <joris.guisson>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: log as req
..../ktorrent/routers file

Description Tom Chiverton 2011-02-15 20:03:13 UTC 
Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

The upnp plugin for ktorrent needs a feature to remember preferred routers so they can be activated automatically once ktorrent is started.

Reproducible: Always

Steps to Reproduce:
Start ktorrent. Go to the upnp tab, press forward.
Close ktorrent.
Start ktorrent, ports not forwarded any more.

Actual Results:  
ports not forwarded any more.

Expected Results:  
ports auto forwarded (if done once in past)
Comment 1 Joris Guisson 2011-02-16 18:46:33 UTC 
> The upnp plugin for ktorrent needs a feature to remember preferred routers so
> they can be activated automatically once ktorrent is started.

This feature has been present ever since UPnP was added.

Not to mention that ports are automatically forwarded once a router is detected.
Comment 2 Tom Chiverton 2011-02-16 19:36:04 UTC 
If that's right, why are no routers or ports listed on the 2nd start in the user story above ?
Comment 3 Joris Guisson 2011-02-17 18:17:38 UTC 
Post your log file of the second run (~/.kde/share/apps/ktorrent/log)

Also what version are you running ?
Comment 4 Tom Chiverton 2011-02-17 19:40:19 UTC 
v4.0.3

To confirm, although there is a device listed on the UPNP panel, no ports are shown as forwarded.
Comment 5 Tom Chiverton 2011-02-17 19:44:52 UTC 
Created attachment 57334 [details]
log as req
Comment 6 Joris Guisson 2011-02-19 11:05:52 UTC 
Could you also post the content of ~/.kde/share/apps/ktorrent/routers ? It's the file where detected routers are stored in.
Comment 7 Tom Chiverton 2011-02-19 11:55:10 UTC 
Created attachment 57373 [details]
..../ktorrent/routers file
Comment 8 Joris Guisson 2011-02-27 20:51:49 UTC 
Git commit 8ed673c90175b65f7eb57bc3cd4868650e1f6907 by Joris.
Committed on 27/02/2011 at 20:47.
Pushed by guisson into branch 'master'.

Revamp UPnP plugin:
- Remove useless connection field from widget
- Forward ports on all detected routers instead of only the default one

BUG: 266397

M  +1    -0    ChangeLog     
M  +28   -33   plugins/upnp/routermodel.cpp     
M  +12   -1    plugins/upnp/routermodel.h     
M  +14   -67   plugins/upnp/upnpwidget.cpp     
M  +0    -1    plugins/upnp/upnpwidget.h     

http://commits.kde.org/ktorrent/8ed673c90175b65f7eb57bc3cd4868650e1f6907