| Summary: | Information about the planet is difficult to see when using a dark color scheme | ||
|---|---|---|---|
| Product: | [Applications] konquest | Reporter: | Mesheryakov Konstanitin <m.keyran> |
| Component: | general | Assignee: | Pierre Ducroquet <pinaraf> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kde-games-bugs |
| Priority: | NOR | ||
| Version: | 2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
Bug fixed in branch 4.7 with commit r1248530 This will soon be in trunk... Thanks for your patch ! |
Version: 2.0 (using KDE 4.6.0) OS: Linux Information about the planets is always displayed on a white background, even when using a white font. Reproducible: Always Steps to Reproduce: Set dark color scheme in system's settings and play the game Actual Results: The white text is completely unreadable on the white background Expected Results: Using background color from system's settings Possible fix: *** old/kdegames-4.6.0/konquest/mapitems.cc 2011-01-19 00:23:00.000000000 +0300 --- new/kdegames-4.6.0/konquest/mapitems.cc 2011-02-05 15:08:11.000000000 +0300 *************** *** 33,38 **** --- 33,39 ---- #include <kglobalsettings.h> #include <klocale.h> #include <kdebug.h> + #include <kcolorscheme.h> #include "mapscene.h" #include "map.h" *************** *** 107,113 **** if ( m_hovered || (m_selected && m_blinkState) ) { QBrush backBrush = p->brush(); ! backBrush.setColor(Qt::white); backBrush.setStyle(Qt::SolidPattern); p->setOpacity(0.3); --- 108,114 ---- if ( m_hovered || (m_selected && m_blinkState) ) { QBrush backBrush = p->brush(); ! backBrush.setColor(KColorScheme(QPalette::Active).background().color()); backBrush.setStyle(Qt::SolidPattern); p->setOpacity(0.3); *************** *** 253,259 **** { QBrush brush = p->brush(); ! brush.setColor(Qt::white); brush.setStyle(Qt::SolidPattern); p->setOpacity(0.7); --- 254,260 ---- { QBrush brush = p->brush(); ! brush.setColor(KColorScheme(QPalette::Active).background().color()); brush.setStyle(Qt::SolidPattern); p->setOpacity(0.7);