Bug 265224

Summary:	Cursor disappears when black background color is selected
Product:	[Unmaintained] kopete	Reporter:	Thomas Damgaard <thomasdn>
Component:	Chat Window	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cfeck, chrivers, lassi.vaatamoinen, nelson
Priority:	NOR
Version:	SVN
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kopete/5cf04ddc300b0408594951b2e7da2f756fafe0fb	Version Fixed In:	4.14.3
Sentry Crash Report:
Attachments:	Proposed patch

Description Thomas Damgaard 2011-02-02 20:21:10 UTC

Version:           SVN (using KDE 4.6.0) 
OS:                Linux

When I chose black as background color in chat windows, the cursor becomes invisible. Because the cursor appearently is always black. This makes it almost impossible to edit a message before posting.

This could be fixed by measuring the light intensity/brightness of the background color. If it is below a certain threshold the cursor will instead be white. 
Another possible solution is to just make the cursor color (and style) configurable in the same dialog as the background color.


Reproducible: Always

Steps to Reproduce:
Set backgruond color of chat window to black

Actual Results:  
Cursor dissappears

Expected Results:  
Cursor should be white.

Comment 1 Christian Iversen 2011-02-04 13:46:37 UTC

I have the opposite problem. Because I use a dark theme in KDE, if I select a light background color in the chat window, the caret becomes effectively invisible since it is the same color.

Comment 2 Nelson Chan 2011-02-04 13:47:18 UTC

do you mean the blinking cursor as you type? in that case
i can confirm this bug on KDE SC 4.6

i think blinking cursor colour should obey base font colour

Comment 3 Thomas Damgaard 2011-02-04 19:02:25 UTC

I agree with Nelson Chan that the text cursor should be same color as font color. If this is made true for all text input fields, it will solve similar problems in other applications as well.

Comment 4 Lassi Väätämöinen 2012-10-05 19:17:27 UTC

Bug still present in Kopete Version 1.3.2 (KDE 4.9.2)

Comment 5 Lassi Väätämöinen 2014-09-22 20:45:01 UTC

(In reply to Lassi Väätämöinen from comment #4)
> Bug still present in Kopete Version 1.3.2 (KDE 4.9.2)

Version 1.6.60
Using KDE Development Platform 4.14.1

Comment 6 Christoph Feck 2014-10-25 16:18:13 UTC

Created attachment 89318 [details]
Proposed patch

Is someone able to test this patch?

Comment 7 Christoph Feck 2014-10-25 18:28:53 UTC

Actually, setting the background color is not required. https://git.reviewboard.kde.org/r/120798/

Comment 8 Christoph Feck 2014-10-28 23:02:55 UTC

Git commit 5cf04ddc300b0408594951b2e7da2f756fafe0fb by Christoph Feck.
Committed on 28/10/2014 at 23:03.
Pushed by cfeck into branch 'KDE/4.14'.

Set style sheet with default text color for cursor color

REVIEW: 120798
FIXED-IN: 4.14.3

M  +2    -0    kopete/chatwindow/chattexteditpart.cpp

http://commits.kde.org/kopete/5cf04ddc300b0408594951b2e7da2f756fafe0fb