Bug 264703

Summary: [PATCH] No quotes for output name in primary startup string
Product: [Applications] systemsettings Reporter: Alexey Chernov <4ernov>
Component: kcm_randrAssignee: Gustavo Pichorim Boiko <gustavo.boiko>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: hbock
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Added quotes to primary output setting startup string

Description Alexey Chernov 2011-01-29 03:03:59 UTC
Created attachment 56599 [details]
Added quotes to primary output setting startup string

Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

There're no quotes for output name in xrandr command string when the primary output is set while everywhere else output names are quoted. I added absent quotes.

Reproducible: Didn't try
Comment 1 Aaron J. Seigo 2011-02-04 08:24:22 UTC
Git commit 77345cff1339ec70b312f68bb315d19ef4fbb2ac by Aaron Seigo.
Committed on 04/02/11 at 08:04.
Pushed by aseigo into branch 'KDE/4.6'.

quote argument

patch by Alexey Chernov
BUG:264703

M  +1    -1    kcontrol/randr/randrconfig.cpp     

http://commits.kde.org/kde-workspace/77345cff1339ec70b312f68bb315d19ef4fbb2ac
Comment 2 Aaron J. Seigo 2011-02-04 08:24:23 UTC
Git commit 08029d6b9c68c0a3941e90168e4a22444b302844 by Aaron Seigo.
Committed on 04/02/11 at 08:04.
Pushed by aseigo into branch 'master'.

quote argument

patch by Alexey Chernov
BUG:264703

M  +1    -1    kcontrol/randr/randrconfig.cpp     

http://commits.kde.org/kde-workspace/08029d6b9c68c0a3941e90168e4a22444b302844
Comment 3 Oswald Buddenhagen 2011-06-19 13:08:42 UTC
this patch created consistency in the wrong direction. reverted and fixed the rest in 9a5c7b5.
Comment 4 Alexey Chernov 2011-06-20 09:14:02 UTC
Oswald, maybe you make some description? The patch was approved by the way. And what if you have xrandr's output name with space like "Screen 0" on my laptop? Will you debug startup command without quotes for me? :)
Comment 5 David Edmundson 2015-01-22 12:07:30 UTC
Thanks for reporting your bug.

Since reporting Krandr has since been replaced by KScreen. It is available in the Plasma 4 series, and is default in Plasma 5 onwards.

I hope this solves your issue. If you still have a problem after upgrading please reopen a new bug under kscreen.

Thanks