Bug 264638

Summary:	stuck when cancelling rename/overwrite dialog in batch queue manager
Product:	[Applications] digikam	Reporter:	Michal Hlavinka <mhlavink>
Component:	AdvancedRename-BatchQueueManager	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	caulier.gilles
Priority:	NOR
Version:	1.8.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:	2.1.0
Sentry Crash Report:

Description Michal Hlavinka 2011-01-28 15:27:55 UTC

Version:           1.8.0 (using KDE 4.6.0) 
OS:                Linux

When you process queue a second time (or just when target files already exists) and have selected "ask for rename/rewrite" in behaviour tab, digikam stucks when you hit cancel button on rename/rewrite dialog. This problem existed in 1.7 and I've just confirmed it exists in 1.8 too.

Reproducible: Always

Steps to Reproduce:
1)add a few images to batch queue (for example resize & convert to png)
2)set behaviour to ask before rename/overwrite
3)start queue
4)stop queue after a few files (now you have conflicting files for next run)
5)start queue again
6)rename/overwrite dialog shows up
7)hit cancel

Actual Results:  
digikam stuck, window not redrawing

Expected Results:  
queue stopped

Severity selected as crash, because it's not just wrong behaviour, but application stops responding.

Comment 1 caulier.gilles 2011-07-06 11:05:44 UTC

We need feedback using a recent version. 2.0.0 RC is out, please test...

Thanks in advance

Gilles Caulier

Comment 2 Michal Hlavinka 2011-07-11 16:14:38 UTC

reproducer still "works", so yes, digikam 2.0 RC (on KDE 4.7 rc1) is still broken

Comment 3 caulier.gilles 2011-09-02 08:52:02 UTC

Git commit 7e36796b0855d5636e5c8be1ec6c407efd1bd3af by Gilles Caulier.
Committed on 02/09/2011 at 10:46.
Pushed by cgilles into branch 'master'.

use timer signal to cancel thread
BUGS: 264638

M  +1    -1    utilities/queuemanager/main/queuemgrwindow.cpp

http://commits.kde.org/digikam/7e36796b0855d5636e5c8be1ec6c407efd1bd3af

Comment 4 caulier.gilles 2011-09-02 09:08:38 UTC

Git commit dfafdc3cd670e8ae567d0a7ebef10926411a69ad by Gilles Caulier.
Committed on 02/09/2011 at 11:07.
Pushed by cgilles into branch 'master'.

better solution is to wait in destructor, not in cancelization method
CCBUGS: 264638

M  +3    -4    utilities/queuemanager/manager/actionthread.cpp
M  +1    -1    utilities/queuemanager/main/queuemgrwindow.cpp

http://commits.kde.org/digikam/dfafdc3cd670e8ae567d0a7ebef10926411a69ad