Bug 264631

Summary: deleteing last TAG on a picture does actually not remove the tag within the exif metadata
Product: [Applications] digikam Reporter: poubelle
Component: Metadata-ExifAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 1.4.0   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 1.9.0
Sentry Crash Report:

Description poubelle 2011-01-28 14:27:07 UTC 
Version:           1.4.0
OS:                Linux

XMP metadata updated and correct if addin Tags to a picture, removing also updates the xmp metadata but when removing the last tag, the tag remains in the file when viewing its medatadata using exiv2

Reproducible: Always

Steps to Reproduce:
Tried the windows Version 1.7 and on ubuntu 10.10 with the 1.4 version, same effect. 

Actual Results:  
last tag remains in the metadata

Expected Results:  
XMP tga should be empty
Comment 1 caulier.gilles 2011-01-28 14:33:44 UTC 
Do you turn on the right option in digiKam/configure Metadata panel ?

Gilles Caulier
Comment 2 poubelle 2011-01-28 16:58:15 UTC 
Well I think so, because when adding tags they will be visible.
Example :
Assigning to A.jpg the tags A/B/C and E/F/G -> using exiv2 both C and G are there with full path
Removing E/F/G : exiv2 return C with full path A/B/C
Now removing A/B/C : exiv2 still returns C with full path A/B/C
In the sqlite database file however the tags are complety removed. Even when Selecting   "Write Metadata to all images", the tag A/B/C still remains when checking with exiv2.

My setting in digiKam/configure : Under Behavious : all checked exept Write Metadata to RAW files and Update file timestamp when metadata are saved.
Comment 3 caulier.gilles 2011-01-28 17:52:24 UTC 
Can you test with last digiKam 1.8.0, just to be sure that dysfunction is not yet fixed with current implementation ?

Gilles Caulier
Comment 4 poubelle 2011-01-28 17:57:54 UTC 
Ok I'll try that, it seems that under Ubuntu 10.10 the 1.8 version is available via ppa so I'll check this out in a VM (don't want to brik my installation). This could take a while, I'll give you feed back as soon as possible.
Comment 5 poubelle 2011-01-28 20:50:11 UTC 
Hi again, I installed version 1.8.0 and the behaviour is still the same. 
By the way, Exiv2 version on my Ubuntu system is 0.19 and on my Windows installaton 0.21.
Comment 6 Marcel Wiesweg 2011-02-09 21:48:14 UTC 
SVN commit 1219633 by mwiesweg:

Fix return value for the case that the bag is empty and removeXmpTag is called:
In this case, do not always return false

CCBUG: 264631


 M  +2 -2      kexiv2xmp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1219633
Comment 7 Marcel Wiesweg 2011-02-09 21:49:42 UTC 
With 2.0 from current git, I had a problem that Xmp.lr.hierarchicalSubject was not removed (because removing Xmp.digiKam.TagsList always returned false), that is fixed now. Now I cannot reproduce any problem with 2.0.
Comment 8 caulier.gilles 2011-02-09 22:28:08 UTC 
Marcel,

Probably i need to backport this commit into KDE 4.5

Gilles
Comment 9 caulier.gilles 2011-02-10 08:45:17 UTC 
SVN commit 1219685 by cgilles:

backport commit #1219633 from trunk to KDE4.5 branch
CCBUGS: 264631


 M  +2 -2      kexiv2xmp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1219685
Comment 10 caulier.gilles 2011-02-10 10:50:07 UTC 
Marcel,

I conform that bug is fixed now.

Gilles Caulier
Comment 11 caulier.gilles 2011-02-10 10:55:28 UTC 
SVN commit 1219697 by cgilles:

backport commit #1219633 from GoSC2010 to trunk (KDE4.7)
CCBUGS: 264631


 M  +2 -2      kexiv2xmp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1219697
Comment 12 caulier.gilles 2011-02-10 10:58:34 UTC 
SVN commit 1219698 by cgilles:

backport commit #1219633 from GoSC2010 to KDE4.6 branch
CCBUGS: 264631


 M  +2 -2      kexiv2xmp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1219698