| Summary: | ksplashx shows garbage when background image does not properly cover entire screen | ||
|---|---|---|---|
| Product: | [Plasma] ksplash | Reporter: | Ivo Anjo <ivo> |
| Component: | general | Assignee: | Lubos Lunak <l.lunak> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Screenshot showing what happens when I replace the background with a smaller one on my desktop (with 2x1280x1024).
Proposed fix |
||
Created attachment 56547 [details]
Proposed fix
I decided to take a stab at solving this, but wow is ksplashx strange.
My fix just makes sure that the createSplashImage function paints the background black before anything else is done.
This patch correctly fixes the issue with the wallpaper size being smaller than the screen size, but I haven't yet tested it on multi-monitor systems; I'll report back soon with those results.
Ok, I've further tested this on two dual-monitor systems, and it works -- including for my friend that had an all-garbage display with the ksplashx theme he was using. I'll redo the patch for git, and submit it to reviewboard next. Git version of the patch is on reviewboard: http://git.reviewboard.kde.org/r/100520/ Sorry to see your patch, wasn't merged. We've changed a lot in Plasma 5. Could you please retest reopen if this is still a problem. Thanks. |
Created attachment 56483 [details] Screenshot showing what happens when I replace the background with a smaller one on my desktop (with 2x1280x1024). Version: unspecified (using KDE 4.6.0) OS: Linux When ksplashx cannot find a proper image, or when you trick it by putting a smaller-sized picture than expected on one of its folders, the parts of the screen that the background doesn't cover show garbage. I'm guessing that some kind of pixmap is being used, and not reset to a default value (such as all black) before the rest of the stuff is used. Note that this is especially bad if you have a strange monitor arrangement -- I have a friend with a rotated monitor and one of the monitors always shows garbage when ksplash starts. Also, it seems that the background.png for 1280x1024 in 4.6 is 1278x1024, and so most users at this resolution will have two pixels of trash. Reproducible: Always