Bug 264092

Summary:	When renaming files JuK clears "genre" field and asks whether to save changes
Product:	[Applications] juk	Reporter:	Michał <mcv>
Component:	general	Assignee:	Scott Wheeler <wheeler>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mpyne
Priority:	NOR
Version:	3.5 (KDE 4.5)
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:	4.6.3
Sentry Crash Report:

Description Michał 2011-01-23 16:56:54 UTC

Version:           3.5 (KDE 4.5) (using KDE 4.5.4) 
OS:                Linux



Reproducible: Always

Steps to Reproduce:
Create a list, edit files data using tag editor. Add "genre" information. Save changes using C-t.

Select files and press C-r to rename files.

Actual Results:  
After confirmation dialog JuK clears "genre" field of selected files and asks for each file whether user want to save changes to the file.

Expected Results:  
Renaming should not affect file tags.

Comment 1 Michael Pyne 2011-04-25 04:40:04 UTC

SVN commit 1229047 by mpyne:

Backport proper tag editor updating to 4.6.3.

Full details are in the commit message for the relevant trunk commit
(r1229044), but this commit essentially properly updates the tag editor on
collection changes so that the displayed title, artist, and genre still
reflect the selected tracks. A bug prior to this fix reset those fields to the
first value in their respective list of possibilities.

This effect does not play well with file renaming, so I believe this also
fixes 271054 (or at least I cannot reproduce it) and the possibly-duplicate
bug 264092 (which would be a dup of 271054 if Michał's genre list had an
empty genre as its first entry). I also cannot reproduce 264092 with this fix,
so please reopen if I've closed the bugs too hastily.

And before I forget: The issue was identified and fixed by Giorgos Kylafas, so
send your thanks (if any) his way. ;)

In case it isn't clear, the 4.6.3 refers to the KDE compilation release, not
the internal JuK version.

CCMAIL:gekylafas@gmail.com
BUG:264092
BUG:271054
FIXED-IN:4.6.3


 M  +4 -1      tageditor.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1229047