Bug 264005

Summary:	unable to preview images with search panel enabled
Product:	[Unmaintained] kdelibs	Reporter:	Zé <mmodem00>
Component:	general	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bbluldd, Ronny.Standtke
Priority:	NOR
Version First Reported In:	SVN
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:	4.6.1
Sentry Crash Report:
Attachments:	patch for the kfilepreviewgenerator class to fix the dolphin-filenamesearch-no-preview-image problem

Description Zé 2011-01-22 20:19:22 UTC

Version:           unspecified (using Devel) 
OS:                Linux

When using dolphin with the search panel (after hitting ctrl+F), dolphin isnt able to preview image files in the preview mode.

This happened me when were in icons folder /usr/share/icons and after doing a search with the previewe mode enabled, the icons resulted from that search were not being previewed, the files resulted from the search were simple being showed with the images default icon (as if the preview mode was not enabled).

To refer that nepomuck is disabled.

Reproducible: Always




OS: Linux (x86_64) release 2.6.36.2-desktop-2mnb
Compiler: gcc

Comment 1 Peter Penz 2011-01-23 15:02:42 UTC

Thanks for the report, I could reproduce the issue.

(internal note: occurs only in the views itself, not for tooltips or the information panel -> check KFilePreviewGenerator)

Comment 2 Peter Penz 2011-01-27 14:42:32 UTC

*** Bug 264479 has been marked as a duplicate of this bug. ***

Comment 3 bbloldd 2011-02-09 20:05:59 UTC

Created attachment 57057 [details]
patch for the kfilepreviewgenerator class to fix the dolphin-filenamesearch-no-preview-image problem

patch for the kfilepreviewgenerator class to fix the dolphin-filenamesearch-no-preview-image problem

Comment 4 bbloldd 2011-02-09 20:07:32 UTC

I have this issue on 4.6.0 too. Dig into the source codes today.

It seems a problem of the KFilePreviewGenerator Class. 

The attached patch fixed the problem from inside KFilePreviewGenerator of kdelibs. 

The KFilePreviewGenerator instance associated with dolphin view
does not correctly update the preview thumbnails for the "filenamesearch" results. This particular thumbnails update is treated as for "oldPreview" in KFilePreviewGenerator::Private::addToPreviewQueue() call. And the preview images are not dispatched, so no preview image is actually shown.

The attached patch forces it to dispatch and update the preview images for the protocol "filenamesearch". 





Each dolphinview (iconview for example) is associated with an instance of KFilePreviewGenerator. When searching without nepomuck, the "filenamesearch" type is involved. To update the dolphinview for the search results, KFilePreviewGenerator->updateIcon is called. But unfortunately, the update is treated as "oldPreview", and refuses to update the preview thumbnail images.

Comment 5 Peter Penz 2011-02-09 21:31:12 UTC

@bbloldd: Thanks a lot for the patch! I'd like to have a look first whether dealing with QStrings here is really the way to go, I think just using KUrl-comparisons might be more general. I'll commit a fix during the next 4 days.

Comment 6 Peter Penz 2011-02-11 22:02:58 UTC

Git commit 1e5ea34d4f2807d769ce5a4793d4a3746f8909a7 by Peter Penz.
Committed on 11/02/2011 at 21:58.
Pushed by ppenz into branch 'master'.

Fix issue that no previews are shown when searching for files

Based on the patch provided by bbloldd at bug 264005

CCBUG: 264005

M  +7    -7    kfile/kfilepreviewgenerator.cpp     

http://commits.kde.org/kdelibs/1e5ea34d4f2807d769ce5a4793d4a3746f8909a7

Comment 7 Peter Penz 2011-02-11 22:21:47 UTC

Git commit b1abd618dcff0920a60631296c560884eb2d4930 by Peter Penz.
Committed on 11/02/2011 at 21:58.
Pushed by ppenz into branch 'KDE/4.6'.

Fix issue that no previews are shown when searching for files

Based on the patch provided by bbloldd at bug 264005

BUG: 264005
FIXED-IN: 4.6.1

M  +7    -7    kfile/kfilepreviewgenerator.cpp     

http://commits.kde.org/kdelibs/b1abd618dcff0920a60631296c560884eb2d4930