| Summary: | add a commandline flag for dynamically specifying reverse-search editor command | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Mark Edgington <medgingto> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | andreas.naumann, nate, patrickmassot |
| Priority: | NOR | ||
| Version First Reported In: | 0.10.5 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/okular/commit/147a638619b4f8bbe80f42b9279c1e993cafc783 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Mark Edgington
2011-01-20 12:10:00 UTC
It seems this is still not fixed in 1.0.3 and I see nothing indicating it's fixed in git master branch. I don't know anything about C but, if it were python, this would be a ten minutes fix, so I guess it can't be much more than an hour of work to make reverse-search actually usable in Okular. In its current state it's usable only provided you have exactly one instance of the target editor opened, or else you need to go to the preference dialog each time you open okular. Indeed, how Okular could know which editor instance to communicate with? Maybe we should be more explicit: what is needed is a command line flag allowing to set the value of what is currently in the preference dialog OkularSettings/editor/command. It would be a great addition to Okular's greatness. The current implementation has a side effect. If one sets the external editor through the commandline, the change will be written to the configuration. Thus when opening other pdfs later, the external editor from the last command-line setting will be used. Git commit 147a638619b4f8bbe80f42b9279c1e993cafc783 by Albert Astals Cid, on behalf of Andreas Naumann. Committed on 18/02/2022 at 13:33. Pushed by aacid into branch 'master'. Adds option editor-cmd to the commandline Adds the option "editor-cmd" for the [feature request](https://bugs.kde.org/show_bug.cgi?id=263732) . M +3 -3 autotests/annotationtoolbartest.cpp M +16 -16 autotests/mainshelltest.cpp M +19 -6 core/document.cpp M +15 -0 core/document.h M +3 -0 core/document_p.h M +8 -3 part/part.cpp M +1 -0 part/part.h M +13 -3 part/preferencesdialog.cpp M +1 -1 part/preferencesdialog.h M +1 -0 shell/main.cpp M +17 -0 shell/okular_main.cpp M +7 -0 shell/shell.cpp M +27 -12 shell/shellutils.cpp M +2 -2 shell/shellutils.h https://invent.kde.org/graphics/okular/commit/147a638619b4f8bbe80f42b9279c1e993cafc783 |