Summary: | Amarok crashed setting album cover | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Christopher Yeleighton <giecrilj> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED DUPLICATE | ||
Severity: | crash | CC: | ralf-engels |
Priority: | NOR | ||
Version: | 2.4.0 | ||
Target Milestone: | 2.4.1 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Patch (copy m_albums to local variable) |
Description
Christopher Yeleighton
2011-01-18 23:03:57 UTC
*** This bug has been marked as a duplicate of bug 197343 *** Sorry Myriam. The bug 197343 crashes in the same function but much earlier and because of another reason. No duplicate. This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. *** This bug has been marked as a duplicate of bug 260854 *** Created attachment 70634 [details]
Patch (copy m_albums to local variable)
This bug was not fixed previously, as I got an identical backtrace with Amarok 2.5.0.
I can reproduce this bug by following steps:
1. play a track (seek to a few seconds before end)
2. trigerring the Set custom cover action
3. wait in the file dialog until the next track starts playing
4. select the new cover
Gdb has shown that the m_albums' data become invalid by the time it enters the foreach at the end of SetCustomCoverAction::slotTriggered. After copying the list to a local variable (see patch), I could not reproduce the bug anymore.
Could you please add your comment to the master bug and paste the relevant KCrashHandler inline there? I will not reopen a report marked as a duplicate |