Bug 263531

Summary:	[PATCH] Track number in album list
Product:	[Applications] amarok	Reporter:	Cédric Bellegarde <web>
Component:	Context View/Albums	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	lfranchi, nicholas, simon.esneault, vianasw
Priority:	NOR
Version:	2.4.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:	2.4.2
Attachments:	Screenshot of bug

Description Cédric Bellegarde 2011-01-18 11:36:12 UTC

Version:           2.4.0 (using KDE 4.5.5) 
OS:                Linux

Album applet display "0. trackname"  when track number isn't set in tags.

Reproducible: Didn't try

Steps to Reproduce:
Display an album with no track number tags

Actual Results:  
"0." displayed

Expected Results:  
It should just display track name without "0."

Comment 1 Nicholas Wilson 2011-03-05 01:51:44 UTC

Do you mean an applet in the context view in the middle? I have checked with some tracks without track numbers, and they display fine in the collection browser.

Comment 2 Cédric Bellegarde 2011-03-05 13:50:40 UTC

Created attachment 57692 [details]
Screenshot of bug

As you can see, track are displayed with 0. in context album view.

Comment 3 Nicholas Wilson 2011-03-06 00:38:21 UTC

Thanks for clarifying that. Patch submitted.
https://git.reviewboard.kde.org/r/100805/

Comment 4 Myriam Schweingruber 2011-06-04 12:16:21 UTC

This is an automated message from the triager:

Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug?

Without feedback within a month we will close this bug as resolved.

Thank you for your understanding.

Comment 5 Myriam Schweingruber 2011-07-17 17:43:18 UTC

NVM, I missed there was a patch, will assign this to a developer ASAP. Sorry for the noise.

Comment 6 Sven Krohlas 2011-07-18 09:35:32 UTC

Git commit 4aeb0ef53df9ce9df3b516ae6dbd5e663b811b22 by Ralf Engels.
Committed on 24/05/2011 at 20:15.
Pushed by rengels into branch 'master'.

A suggested fix for bug 263531. Trivial; changes layout in context view 'albums' applet to prevent "0." appearing in front of tracks with no track number set.

Works with albums having both tracks with and without track numbers. No number is shown for tracks without a track number and the track title is left aligned in the field (or right in RTL layouts).

Courtesy: Nicholas Wilson

M  +6    -2    src/context/applets/albums/AlbumsView.cpp     

http://commits.kde.org/amarok/4aeb0ef53df9ce9df3b516ae6dbd5e663b811b22