Bug 263206

Summary:	[PATCH] kdebase-4.5.5 fails to build (missing include guard in kdebase-4.5.5/apps/nsplugins/viewer/scripting.h)
Product:	[Applications] konqueror	Reporter:	esigra
Component:	nsplugins	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	esigra, martin
Priority:	NOR
Version First Reported In:	4.5.5
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	patch that fixes the build

Description esigra 2011-01-15 09:46:43 UTC

Created attachment 56039 [details]
patch that fixes the build

Version:           unspecified (using KDE 4.5.5) 
OS:                Linux

Previously reported to [http://lists.kde.org/?l=kde-devel&m=129315521001390&w=2].

Reproducible: Always

Steps to Reproduce:
1. tar jxvf kdebase-4.5.5.tar.bz2
2. cd kdebase-4.5.5
3. mkdir build
4. cd build
5. cmake -DKDE4_ENABLE_FINAL=ON ..
6. make

Actual Results:  
In file included from kdebase-4.5.5/apps/nsplugins/viewer/scripting.cpp:30,
                 from kdebase-4.5.5/build/apps/nsplugins/viewer/nspluginviewer_final_cpp.cpp:9:
kdebase-4.5.5/apps/nsplugins/viewer/scripting.h: At global scope:
kdebase-4.5.5/apps/nsplugins/viewer/scripting.h:33: fel: omdefinition av "class kdeNsPluginViewer::ScriptExportEngine"
kdebase-4.5.5/apps/nsplugins/viewer/scripting.h:34: fel: föregående definition av "class kdeNsPluginViewer::ScriptExportEngine"

Comment 1 Martin Koller 2011-06-11 19:44:42 UTC

Please put your patch into the reviewboard.
http://git.reviewboard.kde.org/