Bug 263205

Summary:	Adding user-added certificate in "ssl versions and certificates" wont persist the new added certificate
Product:	[Unmaintained] kdelibs	Reporter:	jens <jp7677>
Component:	kdecore	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	f.bondoux, vesa.muhonen, wstephenson
Priority:	NOR
Version:	4.8
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:	4.8.3
Sentry Crash Report:
Attachments:	correct file pattern matching in kdecore/network/ksslcertificatemanager.cpp

Description jens 2011-01-15 09:30:19 UTC

Version:           unspecified (using KDE 4.5.95) 
OS:                Linux

I tried to add the certificate of my company as user-added certificate to the new certificate kcm panel. After adding the certificate it appears in the list, I can inspect it, but it there anymore after closing and reopening the dialog.

Reproducible: Always

Steps to Reproduce:
- open "ssl versions and certificate"
- add a user-added certificate
- appy and close the window
- reopen "ssl versions and certificate"

Actual Results:  
The list of user-added certificates is empty.

Expected Results:  
My added certificate should be in the list of user-added certificates.

Comment 1 Florent Bondoux 2011-09-28 21:52:24 UTC

Created attachment 64055 [details]
correct file pattern matching in kdecore/network/ksslcertificatemanager.cpp

Comment 2 Florent Bondoux 2011-09-28 21:53:43 UTC

Hi,

I'm seing the same bug : the certificate doesn't show up in the kcm module but is correctly used by e.g. konqueror.

I've tried the attached patch in my gentoo box. It seems to work.
It looks like the extra '/' breaks the pattern matching.

Comment 3 Vesa Muhonen 2012-01-01 19:34:07 UTC

Hi,

It seems that I'm having the same issue here running openSUSE 12.1 Tumbleweed with KDE SC 4.7.2. For me the certificate doesn't show up nor it is used by konqueror or rekonq.

Comment 4 jens 2012-01-15 06:51:48 UTC

@Florent, as far as I know patches attached to bug entries usually get lost. Could you post your patch on kde reviewboard?

Regards,
Jens

Comment 5 Florent Bondoux 2012-03-06 19:56:10 UTC

@Jens
done

Thanks for the suggestion
Florent

Comment 6 jens 2012-04-11 14:27:11 UTC

Hi Florent,

Thanks a lot for posting it on reviewboard (https://git.reviewboard.kde.org/r/104176/). Did you commit you patch or did someone commit for you in the meantime?

Regards, 
Jens

Comment 7 Dawit Alemayehu 2012-04-18 18:38:58 UTC

Git commit 935a374a95190a34f351d4daf01c248e22d303b3 by Dawit Alemayehu.
Committed on 18/04/2012 at 20:36.
Pushed by adawit into branch 'KDE/4.8'.

Make user-added certificates persist in the SSL Preferences dialog.

Patch providedd by Florent Bondoux.
FIXED-IN: 4.8.3
REVIEW: 104176

M  +1    -1    kdecore/network/ksslcertificatemanager.cpp

http://commits.kde.org/kdelibs/935a374a95190a34f351d4daf01c248e22d303b3