Bug 263006

Artem when you say "However, in KDE 4.5" you mean "However, in KDE 4.6"?

Don't know. Kwordquiz's layout switching has already been broken in 4.5. Though, it could be due to some other reason.

Albert, could you please have a look at my bug report #263008 and persuade guys who are responsible for kdelibs to implement my suggestion? I believe that making a well-known centralised list of DBus interface names will spare considerable amount of time that will be spent tracking subsequent DBus name changes.

For important and widely used components, such as kxkb I'd even suggest that a small class be implemented that hides DBus communications from its users. In this way one can take all knowledge of DBus names away from users of DBus interfaces, hence when updating an interface only its facade class will have to be updated and the users will automagically switch to modified DBus interface.

Andriy, could you tell us when you changed kxkb dbus name 4.5 or 4.6?

It was changed in 4.6

Apologies: the only place I knew (and could find) that was using the API was Parley which I changed appropriately

(In reply to comment #5)
> It was changed in 4.6
> 
> Apologies: the only place I knew (and could find) that was using the API was
> Parley which I changed appropriately

Thanks, I would greatly appreciate it if you can commit the necessary changes to KWordQuiz also and close this bug.

Personally i would appreciate if you kept old dbus methods working, you will never know how many programs are out there that are using your dbus methods and will stop working now.

SVN commit 1216174 by rysin:

Use new kxkb dbus APIs
BUG: 263006


 M  +1 -1      dlglanguage.cpp  
 M  +1 -1      kwordquiz.cpp  
 M  +1 -1      kwqtableview.cpp  
 M  +1 -1      qaview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1216174

SVN commit 1216175 by rysin:

Use new kxkb dbus APIs
BUG: 263006
FIXED-IN: 4.6


 M  +1 -1      dlglanguage.cpp  
 M  +1 -1      kwordquiz.cpp  
 M  +1 -1      kwqtableview.cpp  
 M  +1 -1      qaview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1216175

FYI That commit is outside current 4.6.0 tarballs. And i still think you are doing wrong and should make sure your old dbus api still works since you don't know how many other random users might be out there.

(In reply to comment #10)
> FYI That commit is outside current 4.6.0 tarballs. And i still think you are
> doing wrong and should make sure your old dbus api still works since you don't
> know how many other random users might be out there.

Isn't the backport he did http://websvn.kde.org/?view=rev&revision=1216175 enough to cover 4.6?

I agree with you on principle, but at least our own programs are working now.

4.6.0 was tagged yesterday night, if you want this change to be in it you'll have to ask the Dirk Mueller to re-roll the packages with this fix in it.

I was out for a week and I don't have time right now to add the old dbus API back, so I just tried to fix what I could.
BTW I didn't see an email about 4.6.0 tagging, besides I've put fixed-in 4.6 not 4.6.0 :)

SVN commit 1216339 by rysin:

Restore old DBus API: org.kde.kxkb back as an alternative and print deprecation warning if used
BUG: 263006


 M  +25 -1     keyboard_daemon.cpp  
 M  +23 -0     keyboard_daemon.h  
 M  +3 -0      keyboard_dbus.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1216339

Cool :-)