Bug 262595

Summary:	scan dialog shall restore last window size and settings
Product:	[Frameworks and Libraries] libksane	Reporter:	Martin Koller <kollix>
Component:	general	Assignee:	Kåre Särs <kare.sars>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	screenshot of scan dialog from within kolourpaint

Description Martin Koller 2011-01-08 22:43:32 UTC

Version:           unspecified (using KDE 4.5.95) 
OS:                Linux

Switching from KDE3 to KDE4 makes the new scan dialog obvious, but it has some shortcomings in comparison with the predecessor:
- it opens much too small (attached is a screenshot for what I get when opening it from kolourpaint)
- it does not store/restore the window size when I have set my desired size
- it does not store/restore the scanner settings! E.g. I set the scan to 75DPI, but the next time I use the dialog, the DPI setting is back to 600 (which is annoying when one scans a lot of images)

Although kolourpaint does not change the dialog size itself, the dialog does not keep the user defined size even during one kolourpaint session (without exiting it), so I assume the internals of the dialog itself resize it, which is really unfortunate.

Reproducible: Always

Comment 1 Martin Koller 2011-01-08 22:44:30 UTC

Created attachment 55752 [details]
screenshot of scan dialog from within kolourpaint

Comment 2 Kåre Särs 2011-01-09 08:47:28 UTC

Thanks for the report.

There is no code to adjust the dialog, but there should be.

The reason the dialog is back to the minimum size is that the dialog is deleted and recreated.

/Kåre

Comment 3 Martin Koller 2011-01-26 19:36:12 UTC

SVN commit 1217327 by mkoller:

CCBUG: 262595
Add a sane sizeHint for the scan preview widget


 M  +5 -0      ksane_viewer.cpp  
 M  +2 -0      ksane_viewer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1217327

Comment 4 Martin Koller 2011-01-26 19:37:41 UTC

SVN commit 1217328 by mkoller:

Backport r1217327 by mkoller from trunk to the 4.6 branch:

CCBUG: 262595
Add a sane sizeHint for the scan preview widget



 M  +5 -0      ksane_viewer.cpp  
 M  +2 -0      ksane_viewer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1217328

Comment 5 Martin Koller 2011-01-27 18:41:27 UTC

SVN commit 1217506 by mkoller:

BUG: 262595
store/restore scanner dialog size and scanner settings


 M  +25 -1     sanedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1217506

Comment 6 Martin Koller 2011-01-28 22:44:21 UTC

SVN commit 1217820 by mkoller:

Backport from trunk to 4.6 branch
CCBUG: 262595
store/restore scanner dialog size and scanner settings



 M  +25 -1     sanedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1217820