Bug 262313

Summary:	krdc vnc plugins does not set encodings correctly
Product:	[Applications] krdc	Reporter:	Corentin Chary <corentin.chary>
Component:	VNC	Assignee:	Urs Wolfer <uwolfer>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	krdc-vnc-fix-encodings.diff

Description Corentin Chary 2011-01-06 15:42:07 UTC

Version:           unspecified (using Devel) 
OS:                Linux

Even if krdc sets encodingsString, it never calls SetFormatAndEncodings() (see client_examples/SDLVncviewer.c), and thus encodings are not set (checked with wireshark).

Reproducible: Always

Steps to Reproduce:
- Open wireshark and start sniffing
- Connection to a VNC server with krdc
- Check what happened on the network

Actual Results:  
- default libvncserver encodings are sent

Expected Results:  
- encodings sets by krdc are sent

Attached a patch to fix that bug. The patch also reorder encodings: zlib should be before hextile because it's lossless and more efficient.

Comment 1 Corentin Chary 2011-01-06 15:43:36 UTC

Created attachment 55648 [details]
krdc-vnc-fix-encodings.diff

ooops, forgot the patch...

Comment 2 Urs Wolfer 2011-01-07 00:01:14 UTC

SVN commit 1212419 by uwolfer:

Fix setting VNC encodings.

Patch by Corentin Chary <corentin.chary gmail.com>, thanks!

BUG:262313

 M  +4 -3      vncclientthread.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212419

Comment 3 Urs Wolfer 2011-01-07 00:22:35 UTC

SVN commit 1212422 by uwolfer:

Backport to 4.6 branch:

SVN commit 1212419 by uwolfer:

Fix setting VNC encodings.

Patch by Corentin Chary <corentin.chary gmail.com>, thanks!


CCBUG:262313

 M  +4 -3      vncclientthread.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212422