Bug 262030

Summary: "Finish Game" messages are partially untranslatable
Product: [Applications] kigo Reporter: AndrĂ© Marcelo Alvarenga <alvarenga>
Component: generalAssignee: Sascha Peilicke <saschpe>
Status: RESOLVED FIXED    
Severity: normal CC: aspotashev, kde-games-bugs-null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Finish Game message

Description André Marcelo Alvarenga 2011-01-04 04:23:21 UTC
Created attachment 55543 [details]
Finish Game message

Version:           unspecified (using KDE 4.5.90) 
OS:                Linux

See screenshot.
In this message, the first part 'White Player (White)' is untranslatable. Same when 'Black Player (Black)

This message is displayed when you press "Finish Game" or the game over.


Reproducible: Always

Steps to Reproduce:
Finish a game or click in "Finish Game" when is enable.

Actual Results:  
White Player (White) ganhou com um placar de 1,6 (limites: 3,1 e 0,1).

Expected Results:  
Jagador branco (branco) ganhou com um placar de 1,6 (limites: 3,1 e 0,1).

Note: I'm not sure with text in brackets. Is it necessary?

Po messages:

#: gui/mainwindow.cpp:284
#, kde-format
msgid "%1 won with a score of %2 (bounds: %3 and %4)."
msgstr "%1 ganhou com um placar de %2 (limites: %3 e %4)."

Note:
msgstr is now: "O %1 ganhou com %2 pontos (limites: %3 e %4)."
Comment 1 Sascha Peilicke 2011-05-25 09:12:35 UTC
Player names are configurable and stored in $KIGO_SRC_DIR/src/kigo.kcfg and happen to be "White Player" and "Black Player" by default. I could change the default values to be empty and to display sth. translatable in this case, ok?
Comment 2 Alexander Potashev 2011-05-25 12:59:12 UTC
Sounds good.
Comment 3 Alexander Potashev 2011-05-25 13:00:56 UTC
But those names are not configurable from GUI, right?
Comment 4 Sascha Peilicke 2011-05-25 14:11:21 UTC
Sure they are, in the game setup screen.
Comment 5 Justin Zobel 2021-03-09 23:51:03 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 6 Alexander Potashev 2021-03-14 16:25:11 UTC
Same problem in Kigo 0.6.210770. Testing with Russian localization.
Comment 7 Albert Astals Cid 2021-03-14 17:02:10 UTC
Git commit 808ce3263167d99b190af89d35cb859d1ab982b2 by Albert Astals Cid.
Committed on 14/03/2021 at 16:52.
Pushed by aacid into branch 'release/21.04'.

Make the winning color translatable

M  +2    -2    src/gui/mainwindow.cpp

https://invent.kde.org/games/kigo/commit/808ce3263167d99b190af89d35cb859d1ab982b2
Comment 8 Albert Astals Cid 2021-03-14 17:02:18 UTC
Git commit fa2cda77fbf2f64cf5cad7dd8f872276f44c3a45 by Albert Astals Cid.
Committed on 14/03/2021 at 17:01.
Pushed by aacid into branch 'release/21.04'.

Make the default player name translatable

M  +3    -2    src/kigo.kcfg

https://invent.kde.org/games/kigo/commit/fa2cda77fbf2f64cf5cad7dd8f872276f44c3a45