Bug 261386

Summary:	icon preview window keeps growing slowly
Product:	[Plasma] Oxygen	Reporter:	SlashDevDsp <slashdevdsp>
Component:	style	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cfeck, hugo.pereira.da.costa
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description SlashDevDsp 2010-12-27 15:48:40 UTC

Version:           unspecified (using KDE 4.5.90) 
OS:                Linux

right click on a konsole to get 'icon settings' select it and then clicking/selecting the preview tab shows the contents but the window keeps growing slowly

Reproducible: Always

Steps to Reproduce:
1. add a konsole icon to the panel or the desktop containment.
2. right click on the console icon and select 'icon settings'
3. now select the 'preview' tab.


Actual Results:  
if the window is resized (vertically to a smaller size) the window keeps growing vertically but very slowly showing the contents of konsole.desktop file

Expected Results:  
the properties window grows slowly, it should not grow if the window is being resized.

a video highlighting the issue: (click 'Proceed to File Download Page' -> 'Click here to download your file'
http://www.yourfilelink.com/get.php?fid=597022

Comment 1 Christoph Feck 2010-12-27 16:25:51 UTC

Which widget style are you using? If you are using Oxygen could you try Plastique?

Comment 2 SlashDevDsp 2010-12-27 18:39:33 UTC

Yes! this happens only with Oxygen. I have tried plastique and qtcurve and they don't have the same issue.

Comment 3 Hugo Pereira Da Costa 2010-12-28 11:47:51 UTC

I can reproduce. Must be some inconsistency between various pixel metrics in oxygen. Will investigate (not easy though. Might take some time)

Comment 4 Hugo Pereira Da Costa 2010-12-28 11:49:17 UTC

For the record, bug is not present in 4.5 oxygen version.
Must be a side effect/regression from my oxygen rewrite (damn it!)

Comment 5 Hugo Pereira Da Costa 2010-12-28 13:58:15 UTC

SVN commit 1209883 by hpereiradacosta:

Fixed sizeFromContents for tabwidgets (to account for translations in subElementRects, I think).
CCBUG: 261386


 M  +1 -1      oxygenstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1209883

Comment 6 Hugo Pereira Da Costa 2010-12-28 13:59:32 UTC

SVN commit 1209884 by hpereiradacosta:

Backport r1209882 and r1209883.
CCBUG: 261386


 M  +1 -1      oxygenstyle.cpp  
 M  +1 -1      oxygenstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1209884

Comment 7 Hugo Pereira Da Costa 2010-12-28 14:00:16 UTC

That fixes it, in both trunk and KDE4.6 branch.
Closing. Thanks for reporting.

Comment 8 SlashDevDsp 2010-12-29 04:06:24 UTC

Well I have not applied the patch, but could you also check if the preview window does not grow for a text file?

Because I did try the properties->previewtab of a file test.txt with 4 lines in it and the preview tab kept growing.

thanks for the patch, please confirm though :)

Comment 9 Hugo Pereira Da Costa 2010-12-29 09:22:38 UTC

I confirm. I tested both (and actually used the preview tab inside dolphin to debug, cause this was easier than restarting plasma at each code change).