Bug 261370

Summary:	KDE udisks and umount system internal partition behavior
Product:	[Unmaintained] plasma4	Reporter:	Aaron Lewis <the.warl0ck.1989>
Component:	widget-devicenotifier	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	wilderkde
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	4.6.0
Sentry Crash Report:

Description Aaron Lewis 2010-12-27 14:08:20 UTC

Version:           unspecified (using KDE 4.5.90) 
OS:                Linux

Hi , when i clicked on devices in dolphin , say it a partition mounted inside /etc/fstab , and i tried to "umount" it , and fails ( i configured udisks to have this behavior ) , then "device manager" in plasma notification area popups up , it shouldn't popup in this case.

Reproducible: Always

Steps to Reproduce:
1. Create a new partition ( or if you have one )
2. edit fstab to add corresponding entry
3. mount it
4. CLick on "Device Manager" to make sure nothing was displayed
5.. umount it with dolphin , device manager popup ( god , it was hidden in notification area , inactive mode , it shouldn't popup )

Comment 1 Jacopo De Simoi 2010-12-30 13:50:03 UTC

Does the device notifier report an error such as "can not unmount <device>" or does it just pop up without any notifications? 
Thanks

 __J

Comment 2 Aaron Lewis 2010-12-31 01:45:38 UTC

Yes , it has such messages telling me xxx can't be umounted.
( As dolphin already showed this message , i don't think this popup is necessary )

But i didn't configure my Device Manager to show system internal partitions , so i think if there's no plugged devices or CD-ROM at present , it shouldn't popup as user didn't configure to show system internal drives.

What do you think ?

Comment 3 Jacopo De Simoi 2010-12-31 12:09:05 UTC

If the device in question is not shown in the notifier, i agree it should not pop up. On the other hand, if the device _is_ shown in the notifier, it should pop up even if you try to unmount it from another application. 

At the moment the notifier pops up even if the device is not shown; I'll try to fix this behavior shortly. 
Thanks

 __J

Comment 4 Aaron Lewis 2010-12-31 13:22:20 UTC

Great to hear that , as i'm using KDE from trunk now , so please post a comment here when it's fixed , i'll do a update and try out ;-)

Comment 5 Jacopo De Simoi 2010-12-31 13:47:15 UTC

SVN commit 1210440 by jacopods:

Show notifications for visible devices only
BUG: 261370
FIXED-IN: 4.6.0


 M  +2 -1      devicenotifier.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1210440

Comment 6 Jacopo De Simoi 2010-12-31 13:48:56 UTC

SVN commit 1210441 by jacopods:

backport r1210440
CCBUG: 261370


 M  +2 -1      devicenotifier.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1210441

Comment 7 Aaron Lewis 2010-12-31 15:08:44 UTC

Okay , it's now fixed , just updated plsama-workspace

On 12/31/2010 08:48 PM, Jacopo De Simoi wrote:
> https://bugs.kde.org/show_bug.cgi?id=261370
> 
> 
> 
> 
> 
> --- Comment #6 from Jacopo De Simoi <wilderkde gmail com>  2010-12-31 13:48:56 ---
> SVN commit 1210441 by jacopods:
> 
> backport r1210440
> CCBUG: 261370
> 
> 
>  M  +2 -1      devicenotifier.cpp  
> 
> 
> WebSVN link: http://websvn.kde.org/?view=rev&revision=1210441
>