Bug 261125

Summary: "Delete all bookmarks?" window has a button too much
Product: [Applications] marble Reporter: markuss <kamikazow>
Component: generalAssignee: marble-bugs
Status: RESOLVED FIXED    
Severity: normal CC: nienhueser
Priority: NOR    
Version: unspecified   
Target Milestone: 1.0 (KDE 4.6)   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description markuss 2010-12-24 04:16:05 UTC
Version:           unspecified (using KDE 4.5.90) 
OS:                Linux

When selecting Delete All Bookmarks a question appears. It offers three buttons: Yes, No, Cancel.
I see no difference between No and Cancel. Remove the Cancel button, please.

Reproducible: Always
Comment 1 Dennis Nienhüser 2010-12-24 12:15:46 UTC
My thought was that Cancel allows you react quickly when hitting the button accidently (hit Cancel without reading the question). Since you're the second one to mention that it's not necessary I'll probably remove it, don't have a strong opinion on it.
Comment 2 Dennis Nienhüser 2010-12-24 12:34:08 UTC
SVN commit 1209050 by nienhueser:

Remove the Cancel button in the yes/no question.
CCBUG: 261125

 M  +2 -2      QtMainWindow.cpp  
 M  +1 -1      marble_part.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1209050
Comment 3 Dennis Nienhüser 2010-12-24 12:36:06 UTC
SVN commit 1209051 by nienhueser:

Remove the Cancel button in the yes/no question.
BUG: 261125
Backport of commit 1209050.

 M  +2 -2      QtMainWindow.cpp  
 M  +1 -1      marble_part.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1209051