Bug 261062

Summary:	JJ: Mark episodes to keep
Product:	[Applications] amarok	Reporter:	Bart Cerneels <bart.cerneels>
Component:	Podcast	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bart.cerneels, x8lucas8x
Priority:	NOR
Version:	2.4-GIT
Target Milestone:	2.4.0
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:	http://commits.kde.org/amarok/42b37312a71bf5f23f61b8af6820cda9d7bbb4fa	Version Fixed In:	2.7
Sentry Crash Report:
Attachments:	Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked. These "kept" episodes are shown in the list regardless of the purgecount, even if they are not downloaded.

Description Bart Cerneels 2010-12-23 11:43:19 UTC

Version:           2.4-GIT
OS:                Linux

Currently downloaded files are not kept when the episode is no longer shown in the Podcast section. This behavior can not be configured but is tied to the purge settings of each channel.

It's possible to add a "keep downloaded file" checkbox to episodes to prevent the deletion from happening. We should perhaps also show these "kept" episodes in the list regardless of the purgecount. So even if a channel has purgecount 5 and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes.

Reproducible: Always

Comment 1 Lucas Lira Gomes 2011-04-01 17:00:35 UTC

Created attachment 58502 [details]
Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked.  These "kept" episodes are shown in the list regardless of the purgecount, even if they  are not downloaded.

This is the diff between older source code and the source code with my changes.

I tried to fix the bug mentioned here. This is my first time so it may not be
perfect :( I am looking forward for the reviews and I'll try to fix any
problems.
Thank you.

The diff is here too:

https://git.reviewboard.kde.org/r/100998/