Bug 261041

Hmm, looks fine to me

Are you logged in and switched your profile to the new layout?

Can confirm with that.

This problem is caused by us having DOMNode::item (without [[Get]] indexer) which confuses the loader. Seems like FF doesn't need it anymore, so we can just remove it (but add HTMLSelectElement::item). Fixing that makes the page redirect to 127.0.0.1 though :(

Issue #2 is that setDomain of an identical domain is not a no-op; it should set the "domain set from DOM" bit. With that fixed, seems to bootup... (except I was bombarded by certificate validation errors when not logged in... grrr...)

Bug #3 is that XMLHttpRequest should use its domain, not the dynamic one to complete relative URLs.

This is turning out to be an extremely useful bug report. Thank you very much for filling it!

SVN commit 1215544 by orlovich:


Various fixes for the new twitter website:
1) The alleged DOM 0 DOMNode::item doesn't exist in Gecko and WebCore at least,
and it confuses the script loader (as we have NodeList-like .item, but not an 
index [[Get]]). Remove it, but add one to HTMLSelectElement as that's legit 
HTML5.

2) When document.domain is set to the present domain, we still want to call
setDomainFromDOM(), as it would set the 'script-set domain' bit moving the
origin into that namespace --- otherwise it will be inaccessible to other
things that opted in.

3) XMLHttpRequest should complete relative URLs in its own context, not the
dynamic one.

BUG: 261041



 M  +0 -6      ecma/kjs_dom.cpp  
 M  +1 -1      ecma/kjs_dom.h  
 M  +5 -0      ecma/kjs_html.cpp  
 M  +1 -1      ecma/kjs_html.h  
 M  +1 -4      ecma/xmlhttprequest.cpp  
 M  +7 -2      xml/dom_docimpl.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1215544

SVN commit 1215545 by orlovich:

Merged revision:r1215544 | orlovich | 2011-01-18 19:59:02 -0500 (Tue, 18 Jan 2011) | 18 lines


Various fixes for the new twitter website:
1) The alleged DOM 0 DOMNode::item doesn't exist in Gecko and WebCore at least,
and it confuses the script loader (as we have NodeList-like .item, but not an 
index [[Get]]). Remove it, but add one to HTMLSelectElement as that's legit 
HTML5.

2) When document.domain is set to the present domain, we still want to call
setDomainFromDOM(), as it would set the 'script-set domain' bit moving the
origin into that namespace --- otherwise it will be inaccessible to other
things that opted in.

3) XMLHttpRequest should complete relative URLs in its own context, not the
dynamic one.

BUG: 261041

 M  +0 -6      ecma/kjs_dom.cpp  
 M  +1 -1      ecma/kjs_dom.h  
 M  +5 -0      ecma/kjs_html.cpp  
 M  +1 -1      ecma/kjs_html.h  
 M  +1 -4      ecma/xmlhttprequest.cpp  
 M  +7 -2      xml/dom_docimpl.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1215545