Bug 260938

Summary:	Task switcher message when no windows looks ugly with stars
Product:	[Plasma] kwin	Reporter:	Hugo Ortega_H <hugorteg>
Component:	tabbox	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	nathanel.titane
Priority:	NOR
Version:	unspecified
Target Milestone:	4.9
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.9.0
Sentry Crash Report:

Description Hugo Ortega_H 2010-12-22 06:21:21 UTC

Version:           unspecified (using KDE 4.5.2) 
OS:                Linux

When there are no windows on current desktop and the task switcher is used (Alt+Tab) a message "*** No windows ***" appears on a small plasma style box. The problem is the style of the message, because the stars looks very unprofessional and very old school style. I think is a good idea drop the stars and replace with an icon or another nice option.

Reproducible: Always

Steps to Reproduce:
Just press Alt+Tab (or wathever key combination configured) to use the task switcher on a desktop with no windows.

Actual Results:  
The message "*** No windows ***" will appear

Expected Results:  
A nice looking message style, without stars and maybe a nice icon.

Comment 1 Thomas Lübking 2010-12-22 17:19:08 UTC

http://svn.reviewboard.kde.org/r/6187/

you can also enable this setting in "kcmshell4 tabbox", just will always display the desktop...

Comment 2 Martin Flöser 2012-03-11 10:39:44 UTC

I will try to implement this in 4.9 for the new switchers.

Comment 3 Martin Flöser 2012-03-17 06:22:14 UTC

*** Bug 221477 has been marked as a duplicate of this bug. ***

Comment 4 Martin Flöser 2012-03-25 10:00:41 UTC

Git commit cb2c6fd491af7e4135a804ed83cf4acdda9fb54a by Martin Gräßlin.
Committed on 17/03/2012 at 10:31.
Pushed by graesslin into branch 'master'.

Use Show desktop item instead of empty text in TabBox

If there are no windows for Alt+Tab the Show Desktop entry
is shown. This works better with both layouts and effects.
Before this change effects were not activated at all but
a fallback to the layouts was used. Concerning the layouts
some looked rather bad. E.g. Thumbnails did not show a
thumbnail but a legacy text had been shown.

When a window gets added to the empty list, the show desktop
window is removed and consequently when the last window goes
away the show desktop entry is added again.

There is a not considered corner case: if there is no desktop
window, the show desktop functionality is not available and
the behavior is unfortunately undefined. It is a corner case
as we can expect that there is always a desktop window when
using KWin. E.g. there is either Plasma Desktop or Netbook
and on PA there is always at least one window.
FIXED-IN: 4.9.0
REVIEW: 104379

M  +2    -7    kwin/tabbox/clientmodel.cpp
M  +0    -1    kwin/tabbox/clientmodel.h
M  +0    -3    kwin/tabbox/declarative.cpp
M  +2    -3    kwin/tabbox/tabboxhandler.cpp

http://commits.kde.org/kde-workspace/cb2c6fd491af7e4135a804ed83cf4acdda9fb54a