Bug 260825

Summary: Ampersand (&) in module names are displayed as underscore (_) in detailed tooltips
Product: [Plasma] Oxygen Reporter: Burkhard Lück <lueck>
Component: styleAssignee: Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status: RESOLVED FIXED    
Severity: normal CC: cfeck, hugo.pereira.da.costa, sourtooth+ssbugs
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Burkhard Lück 2010-12-20 21:30:51 UTC 
Version:           unspecified (using Devel) 
OS:                Linux

The ampersand (&) in module names are displayed as underscore (_) in detailed tooltips, this effects:
Password & User Account -> Password _User Account
Country/Region & Language -> Country/Region _Language
Size & Orientation -> Size _Orientation


Reproducible: Always

Steps to Reproduce:
Enable "Show detailed tooltips" and hoover Account Details, Locale or Display and Monitor items.

Actual Results:  
ampersand (&) is displayed as underscore (_)

Expected Results:  
ampersand (&) displayed as ampersand (&) like in the individual modules
Comment 1 Ben Cooksley 2010-12-20 22:33:57 UTC 
SVN commit 1208168 by bcooksley:

Show &'s properly.
BUG: 260825

 M  +1 -0      tooltipmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1208168
Comment 2 Christoph Feck 2010-12-28 16:17:44 UTC 
I was skeptical because I could not reproduce. And indeed, after this commit, the ampersands show up twice here, e.g. hovering "Locale" results in a tool tip showing "Country/Region && Language". Not sure why it is different here.
Comment 3 Christoph Feck 2010-12-30 19:37:50 UTC 
The bug isn't in System Settings, but in Oxygen. With other styles I tested (Plastique, Skulpture), the double ampersand was correctly suppressed. Please revert the commit in System Settings, and apply the fix to Oxygen.
Comment 4 Ben Cooksley 2010-12-31 03:08:37 UTC 
I'll revert the change to System Settings only once Hugo has made the change to Oxygen, to avoid a regression in System Settings itself.
Comment 5 Hugo Pereira Da Costa 2010-12-31 11:05:51 UTC 
SVN commit 1210412 by hpereiradacosta:

Changed logic for option-driven disabling keyboard accelerators.
Fixes bug in e.g. systemsettings
CCBUG: 260825 


 M  +5 -4      oxygenstyle.cpp  
 M  +2 -2      oxygenstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1210412
Comment 6 Hugo Pereira Da Costa 2010-12-31 11:07:39 UTC 
SVN commit 1210413 by hpereiradacosta:

Backport r1210412
Changed logic for option-driven disabling keyboard accelerators
Fixes bug in e.g. systemsettings
CCBUG: 260825


 M  +5 -4      oxygenstyle.cpp  
 M  +2 -2      oxygenstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1210413
Comment 7 Hugo Pereira Da Costa 2010-12-31 11:08:20 UTC 
Fixed and backported.
Please close when systemsettings change is reverted.
Comment 8 Ben Cooksley 2011-01-01 05:17:42 UTC 
SVN commit 1210543 by bcooksley:

Revert 1208168, as correct fix is now in Oxygen.
BUG: 260825

 M  +0 -1      tooltipmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1210543
Comment 9 Ben Cooksley 2011-01-01 05:20:43 UTC 
SVN commit 1210544 by bcooksley:

Backport r1210543
Revert 1208168, as correct fix is now in Oxygen.
CCBUG: 260825

 M  +0 -1      tooltipmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1210544